21 Oct, 2015
1 commit
-
This is decrementing the pointer, instead of the value stored in the
pointer. KASan detects it as an out of bounds reference.Reported-by: "Berry Cheng 程君(成淼)"
Signed-off-by: Dan Carpenter
Signed-off-by: David S. Miller
13 Nov, 2014
1 commit
-
Use the normal kernel debugging mechanism which also
enables dynamic_debug at the same time.Other miscellanea:
o Remove sysctl for irda_debug
o Remove function tracing like uses (use ftrace instead)
o Coalesce formats
o Realign arguments
o Remove unnecessary OOM messagesSigned-off-by: Joe Perches
Signed-off-by: David S. Miller
12 Nov, 2014
1 commit
-
And use the more common mechanisms directly.
Other miscellanea:
o Coalesce formats
o Add missing newlines
o Realign arguments
o Remove unnecessary OOM message logging as
there's a generic stack dump already on OOM.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
24 Jun, 2014
1 commit
-
Signed-off-by: Rasmus Villemoes
Signed-off-by: David S. Miller
25 Apr, 2013
1 commit
-
Signed-off-by: Fengguang Wu
Acked-by: Dan Carpenter
Signed-off-by: David S. Miller
20 Apr, 2013
1 commit
-
The "reason" can come from skb->data[] and it hasn't been capped so it
can be from 0-255 instead of just 0-6. For example in irlmp_state_dtr()
the code does:reason = skb->data[3];
...
irlmp_disconnect_indication(self, reason, skb);Also LMREASON has a couple other values which don't have entries in the
irlmp_reasons[] array. And 0xff is a valid reason as well which means
"unknown".So far as I can see we don't actually care about "reason" except for in
the debug code.Signed-off-by: Dan Carpenter
Signed-off-by: David S. Miller
24 Sep, 2010
1 commit
-
Change "return (EXPR);" to "return EXPR;"
return is not a function, parentheses are not required.
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
04 Dec, 2009
1 commit
-
That is "success", "unknown", "through", "performance", "[re|un]mapping"
, "access", "default", "reasonable", "[con]currently", "temperature"
, "channel", "[un]used", "application", "example","hierarchy", "therefore"
, "[over|under]flow", "contiguous", "threshold", "enough" and others.Signed-off-by: André Goddard Rosa
Signed-off-by: Jiri Kosina
14 May, 2008
1 commit
-
Replace u16ho with put/get_unaligned functions
Signed-off-by: Graf Yang
Signed-off-by: Bryan Wu
Signed-off-by: David S. Miller
06 Mar, 2008
1 commit
-
__FUNCTION__ is gcc-specific, use __func__
Signed-off-by: Harvey Harrison
Signed-off-by: David S. Miller
29 Jan, 2008
1 commit
-
By default, LMP sets up a 3 seconds timer for discovery.
We don't need it until discovery is set to 1.Signed-off-by: Ross Burton
Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller
17 Dec, 2007
1 commit
-
While testing the mcs7780 based IrDA USB dongle I've stumbled upon
memory leak in irlmp_unregister_link(). Hashbin for lsaps is created in
irlmp_register_link and should probably be freed in irlmp_unregister_link().Signed-off-by: Hinko Kocevar
Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller
20 Oct, 2007
1 commit
-
* Convert files to UTF-8.
* Also correct some people's names
(one example is Eißfeldt, which was found in a source file.
Given that the author used an ß at all in a source file
indicates that the real name has in fact a 'ß' and not an 'ss',
which is commonly used as a substitute for 'ß' when limited to
7bit.)* Correct town names (Goettingen -> Göttingen)
* Update Eberhard Mönkeberg's address (http://lkml.org/lkml/2007/1/8/313)
Signed-off-by: Jan Engelhardt
Signed-off-by: Adrian Bunk
11 Oct, 2007
1 commit
-
Just switch to the consolidated code
Signed-off-by: Pavel Emelyanov
Signed-off-by: David S. Miller
18 Jul, 2007
1 commit
-
When having built-in IrDA, we hit the following error:
`irda_sysctl_unregister' referenced in section `.init.text' of
net/built-in.o: defined in discarded section `.exit.text' of
net/built-in.o
`irda_proc_unregister' referenced in section `.init.text' of
net/built-in.o: defined in discarded section `.exit.text' of
net/built-in.o
`irsock_cleanup' referenced in section `.init.text' of net/built-in.o:
defined in discarded section `.exit.text' of net/built-in.o
`irttp_cleanup' referenced in section `.init.text' of net/built-in.o:
defined in discarded section `.exit.text' of net/built-in.o
`iriap_cleanup' referenced in section `.init.text' of net/built-in.o:
defined in discarded section `.exit.text' of net/built-in.o
`irda_device_cleanup' referenced in section `.init.text' of
net/built-in.o: defined in discarded section `.exit.text' of
net/built-in.o
`irlap_cleanup' referenced in section `.init.text' of net/built-in.o:
defined in discarded section `.exit.text' of net/built-in.o
`irlmp_cleanup' referenced in section `.init.text' of net/built-in.o:
defined in discarded section `.exit.text' of net/built-in.o
make[1]: *** [.tmp_vmlinux1] Error 1
make: *** [_all] Error 2This is due to the irda_init fix recently added, where we call __exit
routines from an __init one. It is a build failure that I didn't catch
because it doesn't show up when building IrDA as a module. My apologies
for that.
The following patch fixes that failure and is against your net-2.6
tree. I hope it can make it to the merge window, and stable@kernel.org
is CCed on this mail.Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller
11 Jul, 2007
1 commit
-
Make all initialized struct seq_operations in net/ const
Signed-off-by: Philippe De Muyter
Signed-off-by: David S. Miller
13 Feb, 2007
1 commit
-
Many struct file_operations in the kernel can be "const". Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data. In addition it'll catch accidental writes at compile time to
these shared resources.Signed-off-by: Arjan van de Ven
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Feb, 2007
1 commit
-
Signed-off-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller
03 Dec, 2006
1 commit
-
Signed-off-by: Arnaldo Carvalho de Melo
22 Nov, 2006
1 commit
-
On Sat, 2006-11-18 at 16:12 +0300, Andrey Borzenkov wrote:
> =============================================
> [ INFO: possible recursive locking detected ]
> 2.6.19-rc5-2avb #2
> - ---------------------------------------------
> pppd/26425 is trying to acquire lock:
> (&hashbin->hb_spinlock){....}, at: [] irlmp_slsap_inuse+0x5a/0x170
> [irda]
>
> but task is already holding lock:
> (&hashbin->hb_spinlock){....}, at: [] irlmp_slsap_inuse+0x37/0x170
> [irda]
>
> other info that might help us debug this:
> 1 lock held by pppd/26425:
> #0: (&hashbin->hb_spinlock){....}, at: []
> irlmp_slsap_inuse+0x37/0x170 [irda]
>
> stack backtrace:
> [] dump_trace+0x1cc/0x200
> [] show_trace_log_lvl+0x1a/0x30
> [] show_trace+0x12/0x20
> [] dump_stack+0x19/0x20
> [] __lock_acquire+0x8fa/0xc20
> [] lock_acquire+0x5d/0x80
> [] _spin_lock+0x2c/0x40
> [] irlmp_slsap_inuse+0x5a/0x170 [irda]
> [] irlmp_open_lsap+0x62/0x180 [irda]
> [] irttp_open_tsap+0x181/0x230 [irda]
> [] ircomm_open_tsap+0x5d/0xa0 [ircomm]
> [] ircomm_open+0xb8/0xd0 [ircomm]
> [] ircomm_tty_open+0x4f7/0x570 [ircomm_tty]
> [] tty_open+0x174/0x340
> [] chrdev_open+0x89/0x170
> [] __dentry_open+0xa6/0x1d0
> [] nameidata_to_filp+0x35/0x40
> [] do_filp_open+0x49/0x50
> [] do_sys_open+0x47/0xd0
> [] sys_open+0x1c/0x20
> [] sysenter_past_esp+0x56/0x8d
> [] 0xb7f86410
> =======================The comment at the nesting lock says:
/* Careful for priority inversions here !
* irlmp->links is never taken while another IrDA
* spinlock is held, so we are safe. Jean II */So, under the assumption the author was right, it just needs a lockdep
annotation.Signed-off-by: Peter Zijlstra
Acked-by: Ingo Molnar
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller
29 Sep, 2006
1 commit
-
This patch replaces the bunch of arbitrary 64 and 128 bytes alloc_skb() calls
with more accurate allocation sizes.Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller
22 Jul, 2006
2 commits
-
Signed-off-by: Panagiotis Issaris
Signed-off-by: David S. Miller -
As pointed out by Christoph Hellwig, dev_alloc_skb() is not intended to be
used for allocating TX sk_buff. The IrDA stack was exclusively calling
dev_alloc_skb() on the TX path, and this patch fixes that.Signed-off-by: Samuel Ortiz
Signed-off-by: David S. Miller
01 Jul, 2006
1 commit
-
Signed-off-by: Jörn Engel
Signed-off-by: Adrian Bunk
18 Jun, 2006
1 commit
-
irda_device_info->hints[] is byte aligned but is being
accessed as a u16Based upon a patch by Luke Yang .
Signed-off-by: David S. Miller
30 Aug, 2005
1 commit
-
This patch contains the following possible cleanups:
- make the following needlessly global function static:
- irnet/irnet_ppp.c: irnet_init- remove the following unneeded EXPORT_SYMBOL's:
- irlmp.c: sysctl_discovery_timeout
- irlmp.c: irlmp_reasons
- irlmp.c: irlmp_dup
- irqueue.c: hashbin_find_nextSigned-off-by: Adrian Bunk
Signed-off-by: Andrew Morton
Signed-off-by: David S. Miller
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!
