Eric Lee / smarc-fsl-linux-kernel

20 Oct, 2016

1 commit

  • 22d8aa93d   net/ncsi: Improve HNCDSC AEN handler ... Browse Code »

    This improves AEN handler for Host Network Controller Driver Status
    Change (HNCDSC):

    * The channel's lock should be hold when accessing its state.
    * Do failover when host driver isn't ready.
    * Configure channel when host driver becomes ready.

    Signed-off-by: Gavin Shan
    Signed-off-by: David S. Miller

    Gavin Shan
     

04 Oct, 2016

1 commit

  • d8cedaabe   net/ncsi: Avoid unused-value build warning from ia64-linux-gcc ... Browse Code »

    xchg() is used to set NCSI channel's state in order for consistent
    access to the state. xchg()'s return value should be used. Otherwise,
    one build warning will be raised (with -Wunused-value) as below message
    indicates. It is reported by ia64-linux-gcc (GCC) 4.9.0.

    net/ncsi/ncsi-manage.c: In function 'ncsi_channel_monitor':
    arch/ia64/include/uapi/asm/cmpxchg.h:56:2: warning: value computed is \
    not used [-Wunused-value]
    ((__typeof__(*(ptr))) __xchg((unsigned long) (x), (ptr), sizeof(*(ptr))))
    ^
    net/ncsi/ncsi-manage.c:202:3: note: in expansion of macro 'xchg'
    xchg(&nc->state, NCSI_CHANNEL_INACTIVE);

    This removes the atomic access to NCSI channel's state avoid the above
    build warning. We have to hold the channel's lock when its state is readed
    or updated. No functional changes introduced.

    Signed-off-by: Gavin Shan
    Reviewed-by: Joel Stanley
    Signed-off-by: David S. Miller

    Gavin Shan
     

20 Jul, 2016

1 commit

  • 7a82ecf4c   net/ncsi: NCSI AEN packet handler ... Browse Code »

    This introduces NCSI AEN packet handlers that result in (A) the
    currently active channel is reconfigured; (B) Currently active
    channel is deconfigured and disabled, another channel is chosen
    as active one and configured. Case (B) won't happen if hardware
    arbitration has been enabled, the channel that was in active
    state is suspended simply.

    Signed-off-by: Gavin Shan
    Acked-by: Joel Stanley
    Signed-off-by: David S. Miller

    Gavin Shan