19 Jun, 2015
1 commit
-
While testing my netfilter changes I noticed several files where
recompiling unncessarily because they unncessarily included
netfilter.h.Signed-off-by: "Eric W. Biederman"
Signed-off-by: Pablo Neira Ayuso
29 Mar, 2012
1 commit
-
Remove all #inclusions of asm/system.h preparatory to splitting and killing
it. Performed with the following command:perl -p -i -e 's!^#\s*include\s*.*\n!!' `grep -Irl '^#\s*include\s*' *`
Signed-off-by: David Howells
01 Nov, 2011
1 commit
-
These files are non modular, but need to export symbols using
the macros now living in export.h -- call out the include so
that things won't break when we remove the implicit presence
of module.h from everywhere.Signed-off-by: Paul Gortmaker
07 Jul, 2011
1 commit
-
These intefaces haven't existed since 2.2.x
Signed-off-by: David S. Miller
31 Mar, 2011
1 commit
-
Fixes generated by 'codespell' and manually reviewed.
Signed-off-by: Lucas De Marchi
28 Mar, 2011
1 commit
-
Define some constant offsets for CALL_REQUEST based on the description
at and the
definition of ROSE as using 10-digit (5-byte) addresses. Use them
consistently. Validate all implicit and explicit facilities lengths.
Validate the address length byte rather than either trusting or
assuming its value.Signed-off-by: Ben Hutchings
Signed-off-by: David S. Miller
15 Feb, 2011
1 commit
-
FPAC AX25 packet application is using Linux kernel ROSE
routing skills in order to connect or send packets to remote stations
knowing their ROSE address via a network of interconnected nodes.Each FPAC node has a ROSE routing table that Linux ROSE module is
looking at each time a ROSE frame is relayed by the node or when
a connect request to a neighbor node is received.A previous patch improved the system time response by looking at
already established routes each time the system was looking for a
route to relay a frame. If a neighbor node routing the destination
address was already connected, then the frame would be sent
through him. If not, a connection request would be issued.The present patch extends the same routing capability to a connect
request asked by a user locally connected into an FPAC node.
Without this patch, a connect request was not well handled unless it
was directed to an immediate connected neighbor of the local node.Implemented at a number of ROSE FPAC node stations, the present patch
improved dramatically FPAC ROSE routing time response and efficiency.Signed-off-by: Bernard Pidoux
Signed-off-by: David S. Miller
01 Aug, 2010
1 commit
-
The other calls to kmalloc in the same function use GFP_ATOMIC, and indeed
two locks are held within the body of the function.The semantic match that finds this problem is as follows:
(http://coccinelle.lip6.fr/)//
@@ identifier f; @@*f(...,GFP_ATOMIC,...)
... when != spin_unlock(...)
when != read_unlock(...)
when != write_unlock(...)
when != read_unlock_irq(...)
when != write_unlock_irq(...)
when != read_unlock_irqrestore(...)
when != write_unlock_irqrestore(...)
when != spin_unlock_irq(...)
when != spin_unlock_irqrestore(...)
*f(...,GFP_KERNEL,...)
//Signed-off-by: Julia Lawall
Signed-off-by: David S. Miller
30 Mar, 2010
1 commit
-
…it slab.h inclusion from percpu.h
percpu.h is included by sched.h and module.h and thus ends up being
included when building most .c files. percpu.h includes slab.h which
in turn includes gfp.h making everything defined by the two files
universally available and complicating inclusion dependencies.percpu.h -> slab.h dependency is about to be removed. Prepare for
this change by updating users of gfp and slab facilities include those
headers directly instead of assuming availability. As this conversion
needs to touch large number of source files, the following script is
used as the basis of conversion.http://userweb.kernel.org/~tj/misc/slabh-sweep.py
The script does the followings.
* Scan files for gfp and slab usages and update includes such that
only the necessary includes are there. ie. if only gfp is used,
gfp.h, if slab is used, slab.h.* When the script inserts a new include, it looks at the include
blocks and try to put the new include such that its order conforms
to its surrounding. It's put in the include block which contains
core kernel includes, in the same order that the rest are ordered -
alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
doesn't seem to be any matching order.* If the script can't find a place to put a new include (mostly
because the file doesn't have fitting include block), it prints out
an error message indicating which .h file needs to be added to the
file.The conversion was done in the following steps.
1. The initial automatic conversion of all .c files updated slightly
over 4000 files, deleting around 700 includes and adding ~480 gfp.h
and ~3000 slab.h inclusions. The script emitted errors for ~400
files.2. Each error was manually checked. Some didn't need the inclusion,
some needed manual addition while adding it to implementation .h or
embedding .c file was more appropriate for others. This step added
inclusions to around 150 files.3. The script was run again and the output was compared to the edits
from #2 to make sure no file was left behind.4. Several build tests were done and a couple of problems were fixed.
e.g. lib/decompress_*.c used malloc/free() wrappers around slab
APIs requiring slab.h to be added manually.5. The script was run on all .h files but without automatically
editing them as sprinkling gfp.h and slab.h inclusions around .h
files could easily lead to inclusion dependency hell. Most gfp.h
inclusion directives were ignored as stuff from gfp.h was usually
wildly available and often used in preprocessor macros. Each
slab.h inclusion directive was examined and added manually as
necessary.6. percpu.h was updated not to include slab.h.
7. Build test were done on the following configurations and failures
were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
distributed build env didn't work with gcov compiles) and a few
more options had to be turned off depending on archs to make things
build (like ipr on powerpc/64 which failed due to missing writeq).* x86 and x86_64 UP and SMP allmodconfig and a custom test config.
* powerpc and powerpc64 SMP allmodconfig
* sparc and sparc64 SMP allmodconfig
* ia64 SMP allmodconfig
* s390 SMP allmodconfig
* alpha SMP allmodconfig
* um on x86_64 SMP allmodconfig8. percpu.h modifications were reverted so that it could be applied as
a separate patch and serve as bisection point.Given the fact that I had only a couple of failures from tests on step
6, I'm fairly confident about the coverage of this conversion patch.
If there is a breakage, it's likely to be something in one of the arch
headers which should be easily discoverable easily on most builds of
the specific arch.Signed-off-by: Tejun Heo <tj@kernel.org>
Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>
16 Jan, 2010
1 commit
-
Wrong ax25_cb refcounting in ax25_send_frame() and by its callers can
cause timer oopses (first reported with 2.6.29.6 kernel).Fixes: http://bugzilla.kernel.org/show_bug.cgi?id=14905
Reported-by: Bernard Pidoux
Tested-by: Bernard Pidoux
Signed-off-by: Jarek Poplawski
Signed-off-by: David S. Miller
30 Nov, 2009
1 commit
-
Not including net/atm/
Compiled tested x86 allyesconfig only
Added a > 80 column line or two, which I ignored.
Existing checkpatch plaints willfully, cheerfully ignored.Signed-off-by: Joe Perches
Signed-off-by: David S. Miller
06 Nov, 2009
2 commits
-
Conflicts:
drivers/net/usb/cdc_ether.cAll CDC ethernet devices of type USB_CLASS_COMM need to use
'&mbm_info'.Signed-off-by: David S. Miller
-
While hunting dev_put() for net-next-2.6, I found a device refcount
leak in ROSE, ioctl(SIOCADDRT) error path.Fix is to not touch device refcount, as we hold RTNL
Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
04 Nov, 2009
1 commit
-
Adds RCU management to the list of netdevices.
Convert some for_each_netdev() users to RCU version, if
it can avoid read_lock-ing dev_base_lockIe:
read_lock(&dev_base_loack);
for_each_netdev(net, dev)
some_action();
read_unlock(&dev_base_lock);becomes :
rcu_read_lock();
for_each_netdev_rcu(net, dev)
some_action();
rcu_read_unlock();Signed-off-by: Eric Dumazet
Signed-off-by: David S. Miller
27 Jul, 2009
1 commit
-
The use of a static buffer in rose2asc() to return its result is not
threadproof and can result in corruption if multiple threads are trying
to use one of the procfs files based on rose2asc().Signed-off-by: Ralf Baechle
Signed-off-by: David S. Miller
18 Jun, 2008
1 commit
-
ROSE network is organized through nodes connected via hamradio or Internet.
AX25 packet radio frames sent to a remote ROSE address destination are routed
through these nodes.Without the present patch, automatic routing mechanism did not work optimally
due to an improper parameter checking.rose_get_neigh() function is called either by rose_connect() or by
rose_route_frame().In the case of a call from rose_connect(), f0 timer is checked to find if a connection
is already pending. In that case it returns the address of the neighbour, or returns a NULL otherwise.When called by rose_route_frame() the purpose was to route a packet AX25 frame
through an adjacent node given a destination rose address.
However, in that case, t0 timer checked does not indicate if the adjacent node
is actually connected even if the timer is not null. Thus, for each frame sent, the
function often tried to start a new connexion even if the adjacent node was already connected.The patch adds a "new" parameter that is true when the function is called by
rose route_frame().
This instructs rose_get_neigh() to check node parameter "restarted".
If restarted is true it means that the route to the destination address is opened via a neighbour
node already connected.
If "restarted" is false the function returns a NULL.
In that case the calling function will initiate a new connection as before.This results in a fast routing of frames, from nodes to nodes, until
destination is reached, as originaly specified by ROSE protocole.Signed-off-by: Bernard Pidoux
Signed-off-by: David S. Miller
03 May, 2008
1 commit
-
In rose_node_start() as well as in rose_node_stop() __acquires() and
spin_lock_bh() were wrongly passing rose_neigh_list_lock instead of
rose_node_list_lock arguments.Signed-off-by: Bernard Pidoux
Signed-off-by: David S. Miller
21 Apr, 2008
1 commit
-
[ INFO: possible recursive locking detected ]
2.6.25 #3
---------------------------------------------
ax25ipd/3811 is trying to acquire lock:
(rose_node_list_lock){-+..}, at: [] rose_get_neigh+0x1a/0xa0
[rose]but task is already holding lock:
(rose_node_list_lock){-+..}, at: []
rose_route_frame+0x4d/0x620 [rose]other info that might help us debug this:
6 locks held by ax25ipd/3811:
#0: (&tty->atomic_write_lock){--..}, at: []
tty_write_lock+0x1c/0x50
#1: (rcu_read_lock){..--}, at: [] net_rx_action+0x96/0x230
#2: (rcu_read_lock){..--}, at: [] netif_receive_skb+0x100/0x2f0
#3: (rose_node_list_lock){-+..}, at: []
rose_route_frame+0x4d/0x620 [rose]
#4: (rose_neigh_list_lock){-+..}, at: []
rose_route_frame+0x57/0x620 [rose]
#5: (rose_route_list_lock){-+..}, at: []
rose_route_frame+0x61/0x620 [rose]stack backtrace:
Pid: 3811, comm: ax25ipd Not tainted 2.6.25 #3
[] print_deadlock_bug+0xc7/0xd0
[] check_deadlock+0x9a/0xb0
[] validate_chain+0x1e2/0x310
[] ? validate_chain+0xa5/0x310
[] ? native_sched_clock+0x88/0xc0
[] __lock_acquire+0x1a1/0x750
[] lock_acquire+0x81/0xa0
[] ? rose_get_neigh+0x1a/0xa0 [rose]
[] _spin_lock_bh+0x33/0x60
[] ? rose_get_neigh+0x1a/0xa0 [rose]
[] rose_get_neigh+0x1a/0xa0 [rose]
[] rose_route_frame+0x464/0x620 [rose]
[] ? _read_unlock+0x1d/0x20
[] ? rose_route_frame+0x0/0x620 [rose]
[] ax25_rx_iframe+0x66/0x3b0 [ax25]
[] ? ax25_start_t3timer+0x1f/0x40 [ax25]
[] ax25_std_frame_in+0x7fb/0x890 [ax25]
[] ? _spin_unlock_bh+0x25/0x30
[] ax25_kiss_rcv+0x2c6/0x800 [ax25]
[] ? sock_def_readable+0x59/0x80
[] ? __lock_release+0x47/0x70
[] ? sock_def_readable+0x59/0x80
[] ? _read_unlock+0x1d/0x20
[] ? sock_def_readable+0x59/0x80
[] ? sock_queue_rcv_skb+0x13a/0x1d0
[] ? sock_queue_rcv_skb+0x45/0x1d0
[] ? ax25_kiss_rcv+0x0/0x800 [ax25]
[] netif_receive_skb+0x255/0x2f0
[] ? netif_receive_skb+0x100/0x2f0
[] process_backlog+0x7c/0xf0
[] net_rx_action+0x16c/0x230
[] ? net_rx_action+0x96/0x230
[] __do_softirq+0x93/0x120
[] ? mkiss_receive_buf+0x33a/0x3f0 [mkiss]
[] do_softirq+0x57/0x60
[] local_bh_enable_ip+0xa5/0xe0
[] _spin_unlock_bh+0x25/0x30
[] mkiss_receive_buf+0x33a/0x3f0 [mkiss]
[] pty_write+0x47/0x60
[] write_chan+0x1b0/0x220
[] ? tty_write_lock+0x1c/0x50
[] ? default_wake_function+0x0/0x10
[] tty_write+0x12a/0x1c0
[] ? write_chan+0x0/0x220
[] vfs_write+0x96/0x130
[] ? tty_write+0x0/0x1c0
[] sys_write+0x3d/0x70
[] sysenter_past_esp+0x5f/0xa5
=======================
BUG: soft lockup - CPU#0 stuck for 61s! [ax25ipd:3811]Pid: 3811, comm: ax25ipd Not tainted (2.6.25 #3)
EIP: 0060:[] EFLAGS: 00000246 CPU: 0
EIP is at native_read_tsc+0xb/0x20
EAX: b404aa2c EBX: b404a9c9 ECX: 017f1000 EDX: 0000076b
ESI: 00000001 EDI: 00000000 EBP: ecc83afc ESP: ecc83afc
DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
CR0: 8005003b CR2: b7f5f000 CR3: 2cd8e000 CR4: 000006f0
DR0: 00000000 DR1: 00000000 DR2: 00000000 DR3: 00000000
DR6: ffff0ff0 DR7: 00000400
[] delay_tsc+0x17/0x30
[] __delay+0x9/0x10
[] __spin_lock_debug+0x76/0xf0
[] ? spin_bug+0x18/0x100
[] ? __lock_contended+0xa3/0x110
[] _raw_spin_lock+0x68/0x90
[] _spin_lock_bh+0x4f/0x60
[] ? rose_get_neigh+0x1a/0xa0 [rose]
[] rose_get_neigh+0x1a/0xa0 [rose]
[] rose_route_frame+0x464/0x620 [rose]
[] ? _read_unlock+0x1d/0x20
[] ? rose_route_frame+0x0/0x620 [rose]
[] ax25_rx_iframe+0x66/0x3b0 [ax25]
[] ? ax25_start_t3timer+0x1f/0x40 [ax25]
[] ax25_std_frame_in+0x7fb/0x890 [ax25]
[] ? _spin_unlock_bh+0x25/0x30
[] ax25_kiss_rcv+0x2c6/0x800 [ax25]
[] ? sock_def_readable+0x59/0x80
[] ? __lock_release+0x47/0x70
[] ? sock_def_readable+0x59/0x80
[] ? _read_unlock+0x1d/0x20
[] ? sock_def_readable+0x59/0x80
[] ? sock_queue_rcv_skb+0x13a/0x1d0
[] ? sock_queue_rcv_skb+0x45/0x1d0
[] ? ax25_kiss_rcv+0x0/0x800 [ax25]
[] netif_receive_skb+0x255/0x2f0
[] ? netif_receive_skb+0x100/0x2f0
[] process_backlog+0x7c/0xf0
[] net_rx_action+0x16c/0x230
[] ? net_rx_action+0x96/0x230
[] __do_softirq+0x93/0x120
[] ? mkiss_receive_buf+0x33a/0x3f0 [mkiss]
[] do_softirq+0x57/0x60
[] local_bh_enable_ip+0xa5/0xe0
[] _spin_unlock_bh+0x25/0x30
[] mkiss_receive_buf+0x33a/0x3f0 [mkiss]
[] pty_write+0x47/0x60
[] write_chan+0x1b0/0x220
[] ? tty_write_lock+0x1c/0x50
[] ? default_wake_function+0x0/0x10
[] tty_write+0x12a/0x1c0
[] ? write_chan+0x0/0x220
[] vfs_write+0x96/0x130
[] ? tty_write+0x0/0x1c0
[] sys_write+0x3d/0x70
[] sysenter_past_esp+0x5f/0xa5
=======================Since rose_route_frame() does not use rose_node_list we can safely
remove rose_node_list_lock spin lock here and let it be free for
rose_get_neigh().Signed-off-by: Bernard Pidoux
Signed-off-by: David S. Miller
29 Jan, 2008
1 commit
-
CHECK net/rose/af_rose.c
net/rose/af_rose.c:125:11: warning: expensive signed divide
net/rose/af_rose.c:976:46: warning: expensive signed divide
net/rose/af_rose.c:1379:13: warning: context imbalance in 'rose_info_start' - wrong count at exit
net/rose/af_rose.c:1406:13: warning: context imbalance in 'rose_info_stop' - unexpected unlock
CHECK net/rose/rose_in.c
net/rose/rose_in.c:185:25: warning: expensive signed divide
CHECK net/rose/rose_route.c
net/rose/rose_route.c:997:46: warning: expensive signed divide
net/rose/rose_route.c:1070:13: warning: context imbalance in 'rose_node_start' - wrong count at exit
net/rose/rose_route.c:1093:13: warning: context imbalance in 'rose_node_stop' - unexpected unlock
net/rose/rose_route.c:1146:13: warning: context imbalance in 'rose_neigh_start' - wrong count at exit
net/rose/rose_route.c:1169:13: warning: context imbalance in 'rose_neigh_stop' - unexpected unlock
net/rose/rose_route.c:1229:13: warning: context imbalance in 'rose_route_start' - wrong count at exit
net/rose/rose_route.c:1252:13: warning: context imbalance in 'rose_route_stop' - unexpected unlockSigned-off-by: Eric Dumazet
Signed-off-by: David S. Miller
11 Oct, 2007
1 commit
-
This patch makes most of the generic device layer network
namespace safe. This patch makes dev_base_head a
network namespace variable, and then it picks up
a few associated variables. The functions:
dev_getbyhwaddr
dev_getfirsthwbytype
dev_get_by_flags
dev_get_by_name
__dev_get_by_name
dev_get_by_index
__dev_get_by_index
dev_ioctl
dev_ethtool
dev_load
wireless_process_ioctlwere modified to take a network namespace argument, and
deal with it.vlan_ioctl_set and brioctl_set were modified so their
hooks will receive a network namespace argument.So basically anthing in the core of the network stack that was
affected to by the change of dev_base was modified to handle
multiple network namespaces. The rest of the network stack was
simply modified to explicitly use &init_net the initial network
namespace. This can be fixed when those components of the network
stack are modified to handle multiple network namespaces.For now the ifindex generator is left global.
Fundametally ifindex numbers are per namespace, or else
we will have corner case problems with migration when
we get that far.At the same time there are assumptions in the network stack
that the ifindex of a network device won't change. Making
the ifindex number global seems a good compromise until
the network stack can cope with ifindex changes when
you change namespaces, and the like.Signed-off-by: Eric W. Biederman
Signed-off-by: David S. Miller
08 Oct, 2007
1 commit
-
Commit a3d384029aa304f8f3f5355d35f0ae274454f7cd aka
"[AX.25]: Fix unchecked rose_add_loopback_neigh uses"
transformed rose_loopback_neigh var into statically allocated one.
However, on unload it will be kfree's which can't work.Steps to reproduce:
modprobe rose
rmmod roseBUG: unable to handle kernel NULL pointer dereference at virtual address 00000008
printing eip:
c014c664
*pde = 00000000
Oops: 0000 [#1]
PREEMPT DEBUG_PAGEALLOC
Modules linked in: rose ax25 fan ufs loop usbhid rtc snd_intel8x0 snd_ac97_codec ehci_hcd ac97_bus uhci_hcd thermal usbcore button processor evdev sr_mod cdrom
CPU: 0
EIP: 0060:[] Not tainted VLI
EFLAGS: 00210086 (2.6.23-rc9 #3)
EIP is at kfree+0x48/0xa1
eax: 00000556 ebx: c1734aa0 ecx: f6a5e000 edx: f7082000
esi: 00000000 edi: f9a55d20 ebp: 00200287 esp: f6a5ef28
ds: 007b es: 007b fs: 0000 gs: 0033 ss: 0068
Process rmmod (pid: 1823, ti=f6a5e000 task=f7082000 task.ti=f6a5e000)
Stack: f9a55d20 f9a5200c 00000000 00000000 00000000 f6a5e000 f9a5200c f9a55a00
00000000 bf818cf0 f9a51f3f f9a55a00 00000000 c0132c60 65736f72 00000000
f69f9630 f69f9528 c014244a f6a4e900 00200246 f7082000 c01025e6 00000000
Call Trace:
[] rose_rt_free+0x1d/0x49 [rose]
[] rose_rt_free+0x1d/0x49 [rose]
[] rose_exit+0x4c/0xd5 [rose]
[] sys_delete_module+0x15e/0x186
[] remove_vma+0x40/0x45
[] sysenter_past_esp+0x8f/0x99
[] trace_hardirqs_on+0x118/0x13b
[] sysenter_past_esp+0x5f/0x99
=======================
Code: 05 03 1d 80 db 5b c0 8b 03 25 00 40 02 00 3d 00 40 02 00 75 03 8b 5b 0c 8b 73 10 8b 44 24 18 89 44 24 04 9c 5d fa e8 77 df fd ff 56 08 89 f8 e8 84 f4 fd ff e8 bd 32 06 00 3b 5c 86 60 75 0f
EIP: [] kfree+0x48/0xa1 SS:ESP 0068:f6a5ef28Signed-off-by: Alexey Dobriyan
Signed-off-by: David S. Miller
11 Jul, 2007
1 commit
-
Make all initialized struct seq_operations in net/ const
Signed-off-by: Philippe De Muyter
Signed-off-by: David S. Miller
04 May, 2007
1 commit
-
Cleanup of dev_base list use, with the aim to simplify making device
list per-namespace. In almost every occasion, use of dev_base variable
and dev->next pointer could be easily replaced by for_each_netdev
loop. A few most complicated places were converted to using
first_netdev()/next_netdev().Signed-off-by: Pavel Emelianov
Acked-by: Kirill Korotaev
Signed-off-by: David S. Miller
26 Apr, 2007
1 commit
-
For the common, open coded 'skb->h.raw = skb->data' operation, so that we can
later turn skb->h.raw into a offset, reducing the size of struct sk_buff in
64bit land while possibly keeping it as a pointer on 32bit.This one touches just the most simple cases:
skb->h.raw = skb->data;
skb->h.raw = {skb_push|[__]skb_pull}()The next ones will handle the slightly more "complex" cases.
Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
15 Feb, 2007
1 commit
-
After Al Viro (finally) succeeded in removing the sched.h #include in module.h
recently, it makes sense again to remove other superfluous sched.h includes.
There are quite a lot of files which include it but don't actually need
anything defined in there. Presumably these includes were once needed for
macros that used to live in sched.h, but moved to other header files in the
course of cleaning it up.To ease the pain, this time I did not fiddle with any header files and only
removed #includes from .c-files, which tend to cause less trouble.Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
configs in arch/arm/configs on arm. I also checked that no new warnings were
introduced by the patch (actually, some warnings are removed that were emitted
by unnecessarily included header files).Signed-off-by: Tim Schmielau
Acked-by: Russell King
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
13 Feb, 2007
1 commit
-
Many struct file_operations in the kernel can be "const". Marking them const
moves these to the .rodata section, which avoids false sharing with potential
dirty data. In addition it'll catch accidental writes at compile time to
these shared resources.Signed-off-by: Arjan van de Ven
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
11 Feb, 2007
1 commit
-
Signed-off-by: YOSHIFUJI Hideaki
Signed-off-by: David S. Miller
18 Dec, 2006
2 commits
-
rose_add_loopback_neigh uses kmalloc and the callers were ignoring the
error value. Rewrite to let the caller deal with the allocation. This
allows the use of static allocation of kmalloc use entirely.Signed-off-by: Ralf Baechle
Signed-off-by: David S. Miller -
The recent fix 0506d4068bad834aab1141b5dc5e748eb175c6b3 made obvious that
error values were not being propagated through the AX.25 stack. To help
with that this patch marks all kmalloc users in the AX.25, NETROM and
ROSE stacks as __must_check.Signed-off-by: Ralf Baechle
Signed-off-by: David S. Miller
03 Dec, 2006
1 commit
-
David Binderman's icc logs:
net/rose/rose_route.c(399): remark #593: variable "err" was set but never usedSigned-off-by: Alexey Dobriyan
Signed-off-by: David S. Miller
04 May, 2006
2 commits
-
The locking rule for rose_remove_neigh() are that the caller needs to
hold rose_neigh_list_lock, so we better don't take it yet again in
rose_neigh_list_lock.Signed-off-by: Ralf Baechle
Signed-off-by: David S. Miller -
Signed-off-by: Ralf Baechle
Signed-off-by: David S. Miller
09 Nov, 2005
1 commit
-
From: Jesper Juhl
This is the net/ part of the big kfree cleanup patch.
Remove pointless checks for NULL prior to calling kfree() in net/.
Signed-off-by: Jesper Juhl
Cc: "David S. Miller"
Cc: Arnaldo Carvalho de Melo
Acked-by: Marcel Holtmann
Acked-by: YOSHIFUJI Hideaki
Signed-off-by: Andrew Morton
26 Oct, 2005
1 commit
-
Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: Arnaldo Carvalho de Melo
07 Sep, 2005
1 commit
-
Ax2asc was still using a static buffer for all invocations which isn't
exactly SMP-safe. Change ax2asc to take an additional result buffer as
the argument. Change all callers to provide such a buffer.Signed-off-by: Ralf Baechle DL5RB
Signed-off-by: David S. Miller
30 Aug, 2005
1 commit
-
Lots of places just needs the states, not even linux/tcp.h, where this
enum was, needs it.This speeds up development of the refactorings as less sources are
rebuilt when things get moved from net/tcp.h.Signed-off-by: Arnaldo Carvalho de Melo
Signed-off-by: David S. Miller
24 Aug, 2005
2 commits
-
Signed-off-by: David S. Miller
-
Noticed by Coverity checker.
Signed-off-by: David S. Miller
17 Apr, 2005
1 commit
-
Initial git repository build. I'm not bothering with the full history,
even though we have it. We can create a separate "historical" git
archive of that later if we want to, and in the meantime it's about
3.2GB when imported into git - space that would just make the early
git days unnecessarily complicated, when we don't have a lot of good
infrastructure for it.Let it rip!
