Eric Lee / smarc-fsl-linux-kernel

20 Sep, 2016

1 commit

26 Jul, 2016

1 commit

  • a85a970af   net_sched: move tc_action into tcf_common ... Browse Code »

    struct tc_action is confusing, currently we use it for two purposes:
    1) Pass in arguments and carry out results from helper functions
    2) A generic representation for tc actions

    The first one is error-prone, since we need to make sure we don't
    miss anything. This patch aims to get rid of this use, by moving
    tc_action into tcf_common, so that they are allocated together
    in hashtable and can be cast'ed easily.

    And together with the following patch, we could really make
    tc_action a generic representation for all tc actions and each
    type of action can inherit from it.

    Cc: Jamal Hadi Salim
    Signed-off-by: Cong Wang
    Signed-off-by: David S. Miller

    WANG Cong
     

08 Jun, 2016

3 commits

17 May, 2016

1 commit

27 Apr, 2016

1 commit

26 Feb, 2016

1 commit

  • ddf97ccdd   net_sched: add network namespace support for tc actions ... Browse Code »

    Currently tc actions are stored in a per-module hashtable,
    therefore are visible to all network namespaces. This is
    probably the last part of the tc subsystem which is not
    aware of netns now. This patch makes them per-netns,
    several tc action API's need to be adjusted for this.

    The tc action API code is ugly due to historical reasons,
    we need to refactor that code in the future.

    Cc: Jamal Hadi Salim
    Signed-off-by: Cong Wang
    Acked-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    WANG Cong
     

09 Jul, 2015

5 commits

  • 56e5d1ca1   net_sched: act_gact: remove spinlock in fast path ... Browse Code »

    Final step for gact RCU operation :

    1) Use percpu stats
    2) update lastuse only every clock tick to avoid false sharing
    3) Remove spinlock acquisition, as it is no longer needed.

    Since this is the last contended lock in packet RX when tc gact is used,
    this gives impressive gain.

    My host with 8 RX queues was handling 5 Mpps before the patch,
    and more than 11 Mpps after patch.

    Tested:

    On receiver :

    dev=eth0
    tc qdisc del dev $dev ingress 2>/dev/null
    tc qdisc add dev $dev ingress
    tc filter del dev $dev root pref 10 2>/dev/null
    tc filter del dev $dev pref 10 2>/dev/null
    tc filter add dev $dev est 1sec 4sec parent ffff: protocol ip prio 1 \
    u32 match ip src 7.0.0.0/8 flowid 1:15 action drop

    Sender sends packets flood from 7/8 network

    Signed-off-by: Eric Dumazet
    Acked-by: Alexei Starovoitov
    Acked-by: Jamal Hadi Salim
    Acked-by: John Fastabend
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • 8f2ae965b   net_sched: act_gact: read tcfg_ptype once ... Browse Code »

    Third step for gact RCU operation :

    Following patch will get rid of spinlock protection,
    so we need to read tcfg_ptype once.

    Signed-off-by: Eric Dumazet
    Cc: Alexei Starovoitov
    Acked-by: Jamal Hadi Salim
    Acked-by: John Fastabend
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • cc6510a95   net_sched: act_gact: use a separate packet counters for gact_determ() ... Browse Code »

    Second step for gact RCU operation :

    We want to get rid of the spinlock protecting gact operations.
    Stats (packets/bytes) will soon be per cpu.

    gact_determ() would not work without a central packet counter,
    so lets add it for this mode.

    Signed-off-by: Eric Dumazet
    Cc: Alexei Starovoitov
    Acked-by: Jamal Hadi Salim
    Acked-by: John Fastabend
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • cef5ecf96   net_sched: act_gact: make tcfg_pval non zero ... Browse Code »

    First step for gact RCU operation :

    Instead of testing if tcfg_pval is zero or not, just make it 1.

    No change in behavior, but slightly faster code.

    The smp_rmb()/smp_wmb() barriers, while not strictly needed at this
    stage are added for upcoming spinlock removal.

    Signed-off-by: Eric Dumazet
    Acked-by: Alexei Starovoitov
    Acked-by: Jamal Hadi Salim
    Acked-by: John Fastabend
    Signed-off-by: David S. Miller

    Eric Dumazet
     
  • 519c818e8   net: sched: add percpu stats to actions ... Browse Code »

    Reuse existing percpu infrastructure John Fastabend added for qdisc.

    This patch adds a new cpustats parameter to tcf_hash_create() and all
    actions pass false, meaning this patch should have no effect yet.

    Signed-off-by: Eric Dumazet
    Cc: Alexei Starovoitov
    Acked-by: Jamal Hadi Salim
    Acked-by: John Fastabend
    Signed-off-by: David S. Miller

    Eric Dumazet
     

07 Nov, 2014

1 commit

13 Feb, 2014

3 commits

22 Jan, 2014

1 commit

20 Jan, 2014

1 commit

15 Jan, 2014

1 commit

14 Jan, 2014

1 commit

07 Jan, 2014

1 commit

28 Dec, 2013

1 commit

  • 1a29321ed   net_sched: act: Dont increment refcnt on replace ... Browse Code »

    This is a bug fix. The existing code tries to kill many
    birds with one stone: Handling binding of actions to
    filters, new actions and replacing of action
    attributes. A simple test case to illustrate:

    XXXX
    moja@fe1:~$ sudo tc actions add action drop index 12
    moja@fe1:~$ actions get action gact index 12
    action order 1: gact action drop
    random type none pass val 0
    index 12 ref 1 bind 0
    moja@fe1:~$ sudo tc actions replace action ok index 12
    moja@fe1:~$ actions get action gact index 12
    action order 1: gact action drop
    random type none pass val 0
    index 12 ref 2 bind 0
    XXXX

    The above shows the refcounf being wrongly incremented on replace.
    There are more complex scenarios with binding of actions to filters
    that i am leaving out that didnt work as well...

    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    Jamal Hadi Salim
     

21 Dec, 2013

1 commit

  • 568a153a2   net_sched: fix a regression in tc actions ... Browse Code »

    This patch fixes:
    1) pass mask rather than size to tcf_hashinfo_init()
    2) the cleanup should be in reversed order in mirred_cleanup_module()

    Reported-by: Eric Dumazet
    Fixes: 369ba56787d7469c0afd ("net_sched: init struct tcf_hashinfo at register time")
    Cc: Eric Dumazet
    Cc: David S. Miller
    Signed-off-by: Cong Wang
    Signed-off-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    WANG Cong
     

19 Dec, 2013

1 commit

06 Dec, 2013

2 commits

15 Jan, 2013

1 commit

  • c1b52739e   pkt_sched: namespace aware act_mirred ... Browse Code »

    Eric Dumazet pointed out that act_mirred needs to find the current net_ns,
    and struct net pointer is not provided in the call chain. His original
    patch made use of current->nsproxy->net_ns to find the network namespace,
    but this fails to work correctly for userspace code that makes use of
    netlink sockets in different network namespaces. Instead, pass the
    "struct net *" down along the call chain to where it is needed.

    This version removes the ifb changes as Eric has submitted that patch
    separately, but is otherwise identical to the previous version.

    Signed-off-by: Benjamin LaHaise
    Tested-by: Eric Dumazet
    Acked-by: Jamal Hadi Salim
    Signed-off-by: David S. Miller

    Benjamin LaHaise
     

04 Aug, 2012

1 commit

02 Apr, 2012

1 commit

06 Jul, 2011

1 commit

20 Jan, 2011

1 commit

18 Aug, 2010

1 commit

  • 1c40be12f   net sched: fix some kernel memory leaks ... Browse Code »

    We leak at least 32bits of kernel memory to user land in tc dump,
    because we dont init all fields (capab ?) of the dumped structure.

    Use C99 initializers so that holes and non explicit fields are zeroed.

    Signed-off-by: Eric Dumazet
    Signed-off-by: David S. Miller

    Eric Dumazet
     

18 May, 2010

1 commit

  • 6ff9c3644   net sched: printk message severity ... Browse Code »

    The previous patch encourage me to go look at all the messages in
    the network scheduler and fix them. Many messages were missing
    any severity level. Some serious ones that should never happen
    were turned into WARN(), and the random noise messages that were
    handled changed to pr_debug().

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    stephen hemminger
     

26 Nov, 2008

1 commit

20 Jul, 2008

1 commit

29 Jan, 2008

3 commits

11 Jul, 2007

1 commit