21 Feb, 2015

1 commit

  • In tcf_em_validate(), after calling request_module() to load the
    kind-specific module, set em->ops to NULL before returning -EAGAIN, so
    that module_put() is not called again by tcf_em_tree_destroy().

    Signed-off-by: Ignacy Gawędzki
    Acked-by: Cong Wang
    Signed-off-by: David S. Miller

    Ignacy Gawędzki
     

09 Oct, 2014

1 commit


07 Oct, 2014

1 commit

  • This removes the tcf_proto argument from the ematch code paths that
    only need it to reference the net namespace. This allows simplifying
    qdisc code paths especially when we need to tear down the ematch
    from an RCU callback. In this case we can not guarentee that the
    tcf_proto structure is still valid.

    Signed-off-by: John Fastabend
    Acked-by: Cong Wang
    Signed-off-by: David S. Miller

    John Fastabend
     

05 Oct, 2014

1 commit


30 Sep, 2014

1 commit


16 May, 2012

1 commit


02 Apr, 2012

1 commit


20 Jan, 2011

1 commit


18 May, 2010

1 commit

  • The previous patch encourage me to go look at all the messages in
    the network scheduler and fix them. Many messages were missing
    any severity level. Some serious ones that should never happen
    were turned into WARN(), and the random noise messages that were
    handled changed to pr_debug().

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    stephen hemminger
     

30 Mar, 2010

1 commit

  • …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

17 Nov, 2008

1 commit


17 Oct, 2008

1 commit


10 Feb, 2008

2 commits

  • Commit 954415e33ed6cfa932c13e8c2460bd05e50723b5 ("[PKT_SCHED] ematch:
    tcf_em_destroy robustness") removed a cast on em->data when
    passing it to kfree(), but em->data is an integer type that can
    hold pointers as well as other values so the cast is necessary.

    Signed-off-by: David S. Miller

    David S. Miller
     
  • Make the code in tcf_em_tree_destroy more robust and cleaner:
    * Don't need to cast pointer to kfree() or avoid passing NULL.
    * After freeing the tree, clear the pointer to avoid possible problems
    from repeated free.

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Stephen Hemminger
     

09 Feb, 2008

1 commit

  • Setting up a meta match causes a kernel OOPS because of uninitialized
    elements in tree.

    [ 37.322381] BUG: unable to handle kernel NULL pointer dereference at 0000000000000000
    [ 37.322381] IP: [] :em_meta:em_meta_destroy+0x17/0x80

    [ 37.322381] Call Trace:
    [ 37.322381] [] tcf_em_tree_destroy+0x2d/0xa0
    [ 37.322381] [] tcf_em_tree_validate+0x2dc/0x4a0
    [ 37.322381] [] nla_parse+0x92/0xe0
    [ 37.322381] [] :cls_basic:basic_change+0x202/0x3c0
    [ 37.322381] [] kmem_cache_alloc+0x67/0xa0
    [ 37.322381] [] tc_ctl_tfilter+0x3b1/0x580
    [ 37.322381] [] rtnetlink_rcv_msg+0x0/0x260
    [ 37.322381] [] netlink_rcv_skb+0x74/0xa0
    [ 37.322381] [] rtnetlink_rcv+0x18/0x20
    [ 37.322381] [] netlink_unicast+0x263/0x290
    [ 37.322381] [] __alloc_skb+0x96/0x160
    [ 37.322381] [] netlink_sendmsg+0x274/0x340
    [ 37.322381] [] sock_sendmsg+0x12b/0x140
    [ 37.322381] [] autoremove_wake_function+0x0/0x30
    [ 37.322381] [] autoremove_wake_function+0x0/0x30
    [ 37.322381] [] sock_sendmsg+0x12b/0x140
    [ 37.322381] [] zone_statistics+0xb1/0xc0
    [ 37.322381] [] sys_sendmsg+0x20e/0x360
    [ 37.322381] [] sockfd_lookup_light+0x41/0x80
    [ 37.322381] [] handle_mm_fault+0x3eb/0x7f0
    [ 37.322381] [] system_call_after_swapgs+0x7b/0x80

    Signed-off-by: Stephen Hemminger
    Signed-off-by: David S. Miller

    Stephen Hemminger
     

29 Jan, 2008

5 commits


12 Jul, 2007

1 commit


11 Jul, 2007

1 commit


26 Apr, 2007

1 commit

  • So that it is also an offset from skb->head, reduces its size from 8 to 4 bytes
    on 64bit architectures, allowing us to combine the 4 bytes hole left by the
    layer headers conversion, reducing struct sk_buff size to 256 bytes, i.e. 4
    64byte cachelines, and since the sk_buff slab cache is SLAB_HWCACHE_ALIGN...
    :-)

    Many calculations that previously required that skb->{transport,network,
    mac}_header be first converted to a pointer now can be done directly, being
    meaningful as offsets or pointers.

    Signed-off-by: Arnaldo Carvalho de Melo
    Signed-off-by: David S. Miller

    Arnaldo Carvalho de Melo
     

15 Feb, 2007

1 commit

  • After Al Viro (finally) succeeded in removing the sched.h #include in module.h
    recently, it makes sense again to remove other superfluous sched.h includes.
    There are quite a lot of files which include it but don't actually need
    anything defined in there. Presumably these includes were once needed for
    macros that used to live in sched.h, but moved to other header files in the
    course of cleaning it up.

    To ease the pain, this time I did not fiddle with any header files and only
    removed #includes from .c-files, which tend to cause less trouble.

    Compile tested against 2.6.20-rc2 and 2.6.20-rc2-mm2 (with offsets) on alpha,
    arm, i386, ia64, mips, powerpc, and x86_64 with allnoconfig, defconfig,
    allmodconfig, and allyesconfig as well as a few randconfigs on x86_64 and all
    configs in arch/arm/configs on arm. I also checked that no new warnings were
    introduced by the patch (actually, some warnings are removed that were emitted
    by unnecessarily included header files).

    Signed-off-by: Tim Schmielau
    Acked-by: Russell King
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Tim Schmielau
     

11 Feb, 2007

1 commit


03 Dec, 2006

1 commit


22 Jul, 2006

1 commit


01 Jul, 2006

1 commit


12 Jan, 2006

1 commit


09 Nov, 2005

1 commit


17 Apr, 2005

1 commit

  • Initial git repository build. I'm not bothering with the full history,
    even though we have it. We can create a separate "historical" git
    archive of that later if we want to, and in the meantime it's about
    3.2GB when imported into git - space that would just make the early
    git days unnecessarily complicated, when we don't have a lot of good
    infrastructure for it.

    Let it rip!

    Linus Torvalds