11 Apr, 2016
1 commit
-
The 'size' member of a struct firmware is passed to snd_printk with a
respective format string using the %d identifier. The 'size' member is
of type size_t, but format identifier %d indicates a signed int data
type. This patch replaces the %d format identifier with the correct %zu
format identifier for size_t data types.Signed-off-by: William Breathitt Gray
Signed-off-by: Takashi Iwai
28 Jan, 2015
1 commit
-
The soundscape driver uses the ISA inb/outb functions declared
in linux/io.h, so it needs to include this header to avoid
a build error:sscape.c: In function 'sscape_write_unsafe':
sscape.c:203:2: error: implicit declaration of function 'outb' [-Werror=implicit-function-declaration]Signed-off-by: Arnd Bergmann
Signed-off-by: Takashi Iwai
02 Jan, 2015
1 commit
-
Most callers of snd_wss_pcm(), snd_wss_timer() and snd_cs4236_pcm() pass
NULL as the last parameter, some callers pass a pointer but never use it
after the function has been called and only a few callers pass a pointer and
actually use it. The later is only the case for snd_wss_pcm() for
snd_cs4236_pcm() and it is possible to get the same PCM object by accessing
the pcm field of the snd_wss struct that was passed as the first parameter.This function removes the last parameters from the functions mentioned above
and updates the callers which used it to use chip->pcm instead. This allows
us to slightly simplify the functions since they don't have to check and set
the last parameter anymore which makes the code slightly shorter and
cleaner.Signed-off-by: Lars-Peter Clausen
Signed-off-by: Takashi Iwai
12 Feb, 2014
1 commit
-
Also remove superfluous snd_card_set_dev() calls.
Signed-off-by: Takashi Iwai
29 May, 2013
1 commit
-
Similarly like the previous commit for PCI drivers, remove
dev_set_drvdata(NULL) and pnp_set_drvdata(NULL) calls in ISA drivers
now.Signed-off-by: Takashi Iwai
07 Dec, 2012
1 commit
-
CONFIG_HOTPLUG is going away as an option. As result the __dev*
markings will be going away.Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
and __devexit.Signed-off-by: Bill Pemberton
Signed-off-by: Takashi Iwai
10 Apr, 2012
1 commit
-
At the point of this error-handling code, both regions and the dma have
been allocated, so free it as done in previous and subsequent
error-handling code.Signed-off-by: Julia Lawall
Signed-off-by: Takashi Iwai
01 Nov, 2011
1 commit
-
The implicit presence of module.h lured several users into
incorrectly thinking that they only needed/used modparam.h
but once we clean up the module.h presence, these will show
up as build failures, so fix 'em now.Signed-off-by: Paul Gortmaker
14 Sep, 2011
1 commit
-
The semantics of snd_mpu401_uart_new()'s interrupt parameters are
somewhat counterintuitive: To prevent the function from allocating its
own interrupt, either the irq number must be invalid, or the irq_flags
parameter must be zero. At the same time, the irq parameter being
invalid specifies that the mpu401 code has to work without an interrupt
allocated by the caller. This implies that, if there is an interrupt
and it is allocated by the caller, the irq parameter must be set to
a valid-looking number which then isn't actually used.With the removal of IRQF_DISABLED, zero becomes a valid irq_flags value,
which forces us to handle the parameters differently.This patch introduces a new flag MPU401_INFO_IRQ_HOOK for when the
device interrupt is handled by the caller, and makes the allocation of
the interrupt to depend only on the irq parameter. As suggested by
Takashi, the irq_flags parameter was dropped because, when used, it had
the constant value IRQF_DISABLED.Signed-off-by: Clemens Ladisch
Signed-off-by: Takashi Iwai
10 Oct, 2009
1 commit
-
Fix coding style errors in the driver.
Also, add missing argument for CMD_XXX_MIDI_VOL command.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
06 Oct, 2009
2 commits
-
Module parameters shouldn't be marked as __devinitdata since they can be
referred via sysfs even after probing.Signed-off-by: Takashi Iwai
-
Old Soundscape cards (pre PnP) work only with AD1848 codecs.
If the CS4231 codec is installed it must be used in AD1848
compatible mode.Also, add gameport support and remove an unused mpu field.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
04 Oct, 2009
1 commit
-
There is no sense to limit open MIDI connections with limit
as high as ULONG_MAX.Also, convert more messages to use the snd_printk.
Correct few old and misleading comments as well.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
01 Oct, 2009
1 commit
-
The conversion solves the problem that firmware size was set to 64KB
while non PnP cards have 128KB firmware files.An additional firmware initialization code has been moved from the OSS
driver.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
28 Sep, 2009
1 commit
-
Move code from the OSS sscape driver in order to support old Soundscape OEM models.
Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
24 Mar, 2009
1 commit
05 Feb, 2009
1 commit
-
The wss_base is disuised parameter for one function.
It is converted to function parameter.The code_type is only set but never read.
It is removed.The midi_vol is set only to 0 so it does not work
as detection of change in midi volume. It is fixed.The xport variable is alias to the port[dev]. Use
the port[dev] directly to increase readability.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
21 Jan, 2009
1 commit
-
Remove local macros which redefines the
common ones.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
13 Jan, 2009
1 commit
-
A comment states that one should wait up to 5 secs
while a waiting loop waits only 5 system ticks.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
12 Jan, 2009
1 commit
-
Convert from snd_card_new() to the new snd_card_create() function.
Signed-off-by: Takashi Iwai
11 Jan, 2009
1 commit
-
This is required to allow the sscape driver
to autodetect installed codec.Also, do not create a timer if detected codec
has no hardware timer (e.g. AD1848).Signed-off-by: Krzysztof Helt
Cc: Rene Herman
Signed-off-by: Takashi Iwai
06 Aug, 2008
2 commits
-
Rename functions and structures from the former
cs4321_lib to names more corresponding with the
new name: wss_lib.Signed-off-by: Krzysztof Helt
Reviewed-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Rename file include/sound/cs4231.h
into include/sound/wss.hSigned-off-by: Krzysztof Helt
Reviewed-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
01 Feb, 2008
1 commit
-
This header file exists only for some hacks to adapt alsa-driver
tree. It's useless for building in the kernel. Let's move a few
lines in it to sound/core.h and remove it.
With this patch, sound/driver.h isn't removed but has just a single
compile warning to include it. This should be really killed in
future.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
16 Oct, 2007
3 commits
-
Fix schedule_timeout() use in alsa-kernel. Mostly just
schedule_timeout(1) --> schedule_timeout_uninterruptible(1)
The wavefront_synth one fixes the surrounding loop as well. In ymfpci_main,
delete a superfluous set_current_state() and in soc/soc-dapm.c replace an
_interruptible with _uninterruptible in some debug code; it's not waiting
for signals.Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
This patch adds support for audio part of the Ensoniq
SoundScape VIVO cards. The MIDI part is not supported.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
This patch adds second DMA channel and WSS port settings
to the sscape driver. Also, it adds internal card type setting.
The Ensoniq SoundScape VIVO PnP id is added but not handled
yet.Signed-off-by: Krzysztof Helt
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
20 Jul, 2007
1 commit
-
Fixed the invalid use of schedule_timeout_interruptible() without
checking pending signals. Simply replaced with schedule_timeout().
Suggestions thanks to Jeff Garzik.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
16 May, 2007
1 commit
-
isa_register_driver() returns an error if no device is found
and it's no fatal error for the drivers with pnp support.Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
11 May, 2007
2 commits
-
isa_bus: delete snd_ prefix from the (sysfs visible) device/driver names.
Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela -
Port the rest of ALSA ISA drivers to use isa_driver framework
instead of platform_driver.Signed-off-by: Takashi Iwai
Signed-off-by: Jaroslav Kysela
03 Jul, 2006
1 commit
-
Signed-off-by: Thomas Gleixner
Cc: Ingo Molnar
Cc: "David S. Miller"
Cc: Benjamin Herrenschmidt
Cc: Jaroslav Kysela
Cc: Takashi Iwai
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
23 Jun, 2006
1 commit
-
Change the 5th argument of snd_mpu401_uart_new() to bit flags
instead of a boolean. The argument takes bits that consist of
MPU401_INFO_XXX flags.
The callers that used the value 1 there are replaced with
MPU401_INFO_INTEGRATED.Signed-off-by: Takashi Iwai
12 Apr, 2006
2 commits
-
Unregister the platform device again if the probe was unsuccessful.
This restores the behaviour of not loading the driver on probe() failure.
Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai -
Continue with the next one on error from device registration.
This would seem the correct thing to do, even if it's not the probe()
error that we're getting.Signed-off-by: Rene Herman
Signed-off-by: Takashi Iwai
28 Mar, 2006
1 commit
-
Remove the assumption that pnp_register_card_driver() returns the
number of devices claimed.Signed-off-by: Bjorn Helgaas
Cc: Adam Belay
Cc: Jaroslav Kysela
Acked-by: Takashi Iwai
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
22 Jan, 2006
1 commit
-
Fix compilation of some ISA drivers without CONFIG_PNP.
Signed-off-by: Takashi Iwai
03 Jan, 2006
3 commits
-
Call platform_device_unregister() for all platform devices that we've
registered.Signed-off-by: Clemens Ladisch
-
Modules: Sound Scape driver
Rewrite the probe/remove with platform_device.
Signed-off-by: Takashi Iwai
-
Modules: Sound Scape driver
Remove xxx_t typedefs from the ISA SoundScape driver.
Signed-off-by: Takashi Iwai