Eric Lee / smarc-fsl-linux-kernel

25 Jul, 2016

1 commit

17 Jul, 2016

1 commit

  • 275353bb6   ALSA: echoaudio: purge contradictions between dimension matrix members and total number of members ... Browse Code »

    Currently, sound device drivers for PCI cards produced by Echo Audio
    support dimension parameter of element information. But the information
    has contradictions to the number of members of each element. I guess that
    this comes from the assumption that these sound cards are used only by
    'echomixer' in userspace. But ideally, they should be used with usual ALSA
    control applications.

    This commit removes the contradiction. As a result, 'Monitor Mixer Volume'
    and 'VMixer Volume' elements are shown in usual ALSA control applications
    such as 'amixer' and 'alsamixer' in series.

    Signed-off-by: Takashi Sakamoto
    Signed-off-by: Takashi Iwai

    Takashi Sakamoto
     

28 Jun, 2016

1 commit

  • 9c6795a9b   ALSA: echoaudio: Fix memory allocation ... Browse Code »

    'commpage_bak' is allocated with 'sizeof(struct echoaudio)' bytes.
    We then copy 'sizeof(struct comm_page)' bytes in it.
    On my system, smatch complains because one is 2960 and the other is 3072.

    This would result in memory corruption or a oops.

    Signed-off-by: Christophe JAILLET
    Cc:
    Signed-off-by: Takashi Iwai

    Christophe JAILLET
     

10 Aug, 2015

1 commit

  • 3f6175ece   ALSA: echoaudio: Use standard C definitions of true and false ... Browse Code »

    The echoaudio locally defines TRUE and FALSE. Not only is this
    redundant given that C now has a boolean type it results in lots of
    warnings as other headers also define these macros, causing duplicate
    definitions. Fix this by removing the local defines and converting all
    local users to use the standard C true and false instead, simply
    removing the macros is less safe due to implicit inclusion of the other
    definitons.

    [fixed overlooked replacement of FALSE by tiwai]

    Signed-off-by: Mark Brown
    Signed-off-by: Takashi Iwai

    Mark Brown
     

23 Mar, 2015

1 commit

  • 77008b70f   ALSA: echoaudio: read past end of array ... Browse Code »

    We need to cap "ucontrol->id.index / num_busses_in(chip)" so the we
    don't read beyond the end of the array.

    I also adding a check on "in" and changing the type in
    snd_echo_mixer_put() from short to unsigned int. Those changes are done
    for symmetry and are cosmetic.

    Signed-off-by: Dan Carpenter
    Signed-off-by: Takashi Iwai

    Dan Carpenter
     

28 Jan, 2015

1 commit

19 Jan, 2015

1 commit

11 Jan, 2015

1 commit

09 Jan, 2015

1 commit

  • f84edab4b   ALSA: echoaudio: Simplify PM callbacks ... Browse Code »

    This is a similar cleanup like the commit [3db084fd0af5: ALSA: fm801:
    PCI core handles power state for us].

    Since pci_set_power_state(), pci_save_state() and pci_restore_state()
    are already done in the PCI core side, so we don't need to it doubly.

    Also, pci_enable_device(), pci_disable_device() and pci_set_master()
    calls in PM callbacks are superfluous nowadays, too, so get rid of
    them as well.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

04 Jan, 2015

1 commit

03 Dec, 2014

1 commit

05 Nov, 2014

1 commit

  • 9161bd0d1   ALSA: echoaudio: cleanup of unnecessary messages ... Browse Code »

    commit "b5b4a41b392960010fccf1f9ccf8334d612bd450" was dereferencing
    chip after it has been freed. This patch fixes that and at the same
    time removes some debugging messages, which are unnecessary, as they
    are just printing information about entry and exit from a function,
    and which switch-case it is executing.
    we can easily get from ftrace the information about the entry and exit
    from a function.

    Reported-by: Dan Carpenter
    Signed-off-by: Sudip Mukherjee
    Signed-off-by: Takashi Iwai

    Sudip Mukherjee
     

03 Nov, 2014

2 commits

21 Oct, 2014

1 commit

13 Aug, 2014

1 commit

  • 9baa3c34a   PCI: Remove DEFINE_PCI_DEVICE_TABLE macro use ... Browse Code »

    We should prefer `struct pci_device_id` over `DEFINE_PCI_DEVICE_TABLE` to
    meet kernel coding style guidelines. This issue was reported by checkpatch.

    A simplified version of the semantic patch that makes this change is as
    follows (http://coccinelle.lip6.fr/):

    //

    @@
    identifier i;
    declarer name DEFINE_PCI_DEVICE_TABLE;
    initializer z;
    @@

    - DEFINE_PCI_DEVICE_TABLE(i)
    + const struct pci_device_id i[]
    = z;

    //

    [bhelgaas: add semantic patch]
    Signed-off-by: Benoit Taine
    Signed-off-by: Bjorn Helgaas

    Benoit Taine
     

01 Jul, 2014

1 commit

05 Mar, 2014

1 commit

26 Feb, 2014

1 commit

12 Feb, 2014

1 commit

29 May, 2013

1 commit

  • 20a24225d   ALSA: PCI: Remove superfluous pci_set_drvdata(pci, NULL) at remove ... Browse Code »

    As drvdata is cleared to NULL at probe failure or at removal by the
    driver core, we don't have to call pci_set_drvdata(pci, NULL) any
    longer in each driver.

    The only remaining pci_set_drvdata(NULL) is in azx_firmware_cb() in
    hda_intel.c. Since this function itself releases the card instance,
    we need to clear drvdata here as well, so that it won't be released
    doubly in the remove callback.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

07 Dec, 2012

1 commit

  • e23e7a143   ALSA: pci: remove __dev* attributes ... Browse Code »

    CONFIG_HOTPLUG is going away as an option. As result the __dev*
    markings will be going away.

    Remove use of __devinit, __devexit_p, __devinitdata, __devinitconst,
    and __devexit.

    Signed-off-by: Bill Pemberton
    Signed-off-by: Takashi Iwai

    Bill Pemberton
     

15 Aug, 2012

1 commit

03 Jul, 2012

1 commit

21 May, 2012

1 commit

06 May, 2012

1 commit

  • c914f55f7   ALSA: echoaudio: Remove incorrect part of assertion ... Browse Code »
    1

    This assertion seems to imply that chip->dsp_code_to_load is a pointer.
    It's actually an integer handle on the actual firmware, and 0 has no
    special meaning.

    The assertion prevents initialisation of a Darla20 card, but would also
    affect other models. It seems it was introduced in commit dd7b254d.

    ALSA sound/pci/echoaudio/echoaudio.c:2061 Echoaudio driver starting...
    ALSA sound/pci/echoaudio/echoaudio.c:1969 chip=ebe4e000
    ALSA sound/pci/echoaudio/echoaudio.c:2007 pci=ed568000 irq=19 subdev=0010 Init hardware...
    ALSA sound/pci/echoaudio/darla20_dsp.c:36 init_hw() - Darla20
    ------------[ cut here ]------------
    WARNING: at sound/pci/echoaudio/echoaudio_dsp.c:478 init_hw+0x1d1/0x86c [snd_darla20]()
    Hardware name: Dell DM051
    BUG? (!chip->dsp_code_to_load || !chip->comm_page)

    Signed-off-by: Mark Hills
    Cc:
    Signed-off-by: Takashi Iwai

    Mark Hills
     

24 Apr, 2012

1 commit

19 Dec, 2011

1 commit

  • a67ff6a54   ALSA: module_param: make bool parameters really bool ... Browse Code »

    module_param(bool) used to counter-intuitively take an int. In
    fddd5201 (mid-2009) we allowed bool or int/unsigned int using a messy
    trick.

    It's time to remove the int/unsigned int option. For this version
    it'll simply give a warning, but it'll break next kernel version.

    Signed-off-by: Rusty Russell
    Signed-off-by: Takashi Iwai

    Rusty Russell
     

01 Nov, 2011

2 commits

27 Jul, 2011

1 commit

  • 60063497a   atomic: use <linux/atomic.h> ... Browse Code »

    This allows us to move duplicated code in
    (atomic_inc_not_zero() for now) to

    Signed-off-by: Arun Sharma
    Reviewed-by: Eric Dumazet
    Cc: Ingo Molnar
    Cc: David Miller
    Cc: Eric Dumazet
    Acked-by: Mike Frysinger
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Arun Sharma
     

10 Jun, 2011

2 commits

  • 934c2b6d0   ALSA: use KBUILD_MODNAME for request_irq argument in sound/pci/* ... Browse Code »

    The name argument of request_irq() appears in /proc/interrupts, and
    it's quite ugly when the name entry contains a space or special letters.
    In general, it's simpler and more readable when the module name appears
    there, so let's replace all entries with KBUILD_MODNAME.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     
  • 3733e424c   ALSA: Use KBUILD_MODNAME for pci_driver.name entries ... Browse Code »

    The convention for pci_driver.name entry in kernel drivers seem to be
    the module name or equivalent ones. But, so far, almost all PCI sound
    drivers use more verbose name like "ABC Xyz (12)", and these are fairly
    confusing when appearing as a file name.

    This patch converts the all pci_driver.name entries in sound/pci/* to
    use KBUILD_MODNAME for more unified appearance.

    Signed-off-by: Takashi Iwai

    Takashi Iwai
     

19 Jul, 2010

1 commit

07 Apr, 2010

1 commit

  • 84db18bbe   Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6 ... Browse Code »

    * 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound-2.6:
    ALSA: mixart: range checking proc file
    ALSA: hda - Fix a wrong array range check in patch_realtek.c
    ALSA: ASoC: move dma_data from snd_soc_dai to snd_soc_pcm_stream
    ALSA: hda - Enable amplifiers on Acer Inspire 6530G
    ASoC: Only do WM8994 bias off transition from standby
    ASoC: Don't use DCS_DATAPATH_BUSY for WM hubs devices
    ASoC: Don't do runtime wm_hubs DC servo updates if using offset correction
    ASoC: Support second DC servo readback method for wm_hubs
    ASoC: Avoid wraparound in wm_hubs DC servo correction
    ALSA: echoaudio - Eliminate use after free
    ALSA: i2c: cleanup: change parameter to pointer
    ALSA: hda - Add MSI blacklist for Aopen MZ915-M
    ASoC: OMAP: Fix capture pointer handling for OMAP1510 to work correctly with recent ALSA PCM code
    ALSA: hda - Update document about MSI and interrupts
    ALSA: hda: Fix 0 dB offset for Lenovo Thinkpad models using AD1981
    ALSA: hda - Add missing printk argument in previous patch
    ASoC: Fix passing platform_data to ac97 bus users and fix a leak
    ALSA: hda - Fix ADC/MUX assignment of ALC269 codec
    ALSA: hda - Fix invalid bit values passed to snd_hda_codec_amp_stereo()
    ASoC: wm8994: playback => capture

    Linus Torvalds
     

04 Apr, 2010

1 commit

  • a0fd4345f   ALSA: echoaudio - Eliminate use after free ... Browse Code »

    Use the call to snd_card_free in the error handling code at the end of the
    function, as in the other error cases.

    A simplified version of the semantic patch that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @@
    expression E,E2;
    @@

    snd_card_free(E)
    ...
    (
    E = E2
    |
    * E
    )
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Takashi Iwai

    Julia Lawall
     

30 Mar, 2010

1 commit

  • 5a0e3ad6a   include cleanup: Update gfp.h and slab.h includes to prepare for breaking implic… ... Browse Code »

    …it slab.h inclusion from percpu.h

    percpu.h is included by sched.h and module.h and thus ends up being
    included when building most .c files. percpu.h includes slab.h which
    in turn includes gfp.h making everything defined by the two files
    universally available and complicating inclusion dependencies.

    percpu.h -> slab.h dependency is about to be removed. Prepare for
    this change by updating users of gfp and slab facilities include those
    headers directly instead of assuming availability. As this conversion
    needs to touch large number of source files, the following script is
    used as the basis of conversion.

    http://userweb.kernel.org/~tj/misc/slabh-sweep.py

    The script does the followings.

    * Scan files for gfp and slab usages and update includes such that
    only the necessary includes are there. ie. if only gfp is used,
    gfp.h, if slab is used, slab.h.

    * When the script inserts a new include, it looks at the include
    blocks and try to put the new include such that its order conforms
    to its surrounding. It's put in the include block which contains
    core kernel includes, in the same order that the rest are ordered -
    alphabetical, Christmas tree, rev-Xmas-tree or at the end if there
    doesn't seem to be any matching order.

    * If the script can't find a place to put a new include (mostly
    because the file doesn't have fitting include block), it prints out
    an error message indicating which .h file needs to be added to the
    file.

    The conversion was done in the following steps.

    1. The initial automatic conversion of all .c files updated slightly
    over 4000 files, deleting around 700 includes and adding ~480 gfp.h
    and ~3000 slab.h inclusions. The script emitted errors for ~400
    files.

    2. Each error was manually checked. Some didn't need the inclusion,
    some needed manual addition while adding it to implementation .h or
    embedding .c file was more appropriate for others. This step added
    inclusions to around 150 files.

    3. The script was run again and the output was compared to the edits
    from #2 to make sure no file was left behind.

    4. Several build tests were done and a couple of problems were fixed.
    e.g. lib/decompress_*.c used malloc/free() wrappers around slab
    APIs requiring slab.h to be added manually.

    5. The script was run on all .h files but without automatically
    editing them as sprinkling gfp.h and slab.h inclusions around .h
    files could easily lead to inclusion dependency hell. Most gfp.h
    inclusion directives were ignored as stuff from gfp.h was usually
    wildly available and often used in preprocessor macros. Each
    slab.h inclusion directive was examined and added manually as
    necessary.

    6. percpu.h was updated not to include slab.h.

    7. Build test were done on the following configurations and failures
    were fixed. CONFIG_GCOV_KERNEL was turned off for all tests (as my
    distributed build env didn't work with gcov compiles) and a few
    more options had to be turned off depending on archs to make things
    build (like ipr on powerpc/64 which failed due to missing writeq).

    * x86 and x86_64 UP and SMP allmodconfig and a custom test config.
    * powerpc and powerpc64 SMP allmodconfig
    * sparc and sparc64 SMP allmodconfig
    * ia64 SMP allmodconfig
    * s390 SMP allmodconfig
    * alpha SMP allmodconfig
    * um on x86_64 SMP allmodconfig

    8. percpu.h modifications were reverted so that it could be applied as
    a separate patch and serve as bisection point.

    Given the fact that I had only a couple of failures from tests on step
    6, I'm fairly confident about the coverage of this conversion patch.
    If there is a breakage, it's likely to be something in one of the arch
    headers which should be easily discoverable easily on most builds of
    the specific arch.

    Signed-off-by: Tejun Heo <tj@kernel.org>
    Guess-its-ok-by: Christoph Lameter <cl@linux-foundation.org>
    Cc: Ingo Molnar <mingo@redhat.com>
    Cc: Lee Schermerhorn <Lee.Schermerhorn@hp.com>

    Tejun Heo
     

17 Feb, 2010

2 commits

  • 7fb3a069b   Merge branch 'fix/misc' into topic/misc ... Browse Code »

    Conflicts:
    sound/pci/hda/patch_realtek.c

    Takashi Iwai
     
  • b721e68bd   ALSA: Echoaudio, fix Guru Meditation #00000005.48454C50 ... Browse Code »

    This patch fixes a division by zero error in the irq handler.

    There is a small window between the hw_params() callback and when
    runtime->frame_bits is set by ALSA middle layer. When another substream is
    already running, if an interrupt is delivered during that window the irq
    handler calls pcm_pointer() which does a division by zero. The patch below
    makes the irq handler skip substreams that are initialized but not started
    yet. Cc to Clemens Ladisch because he proposed an alternate fix.

    For more information, please read the original thread in the linux-kernel
    mailing list: http://lkml.org/lkml/2010/2/2/187

    Signed-off-by: Giuliano Pochini
    Signed-off-by: Takashi Iwai

    Giuliano Pochini
     

15 Feb, 2010

1 commit

  • 47b5d028f   ALSA: Echoaudio - Add suspend support #2 ... Browse Code »

    This patch adds rearranges parts of the initialization code and adds
    suspend and resume callbacks.

    This patch adds suspend and resume callbacks.
    It also rearranges parts of the initialization code so it can be
    used in both the first initialization (when the module is loaded we
    also have to load default settings) and the resume callback (where
    we have to restore the previous settings).

    Signed-off-by: Giuliano Pochini
    Signed-off-by: Takashi Iwai

    Giuliano Pochini