18 May, 2017

2 commits


28 Oct, 2016

1 commit

  • It makes the result hard to interpret correctly if a base 10 number is
    prefixed by 0x. So change to a hex number.

    Link: http://lkml.kernel.org/r/20161026125658.25728-4-u.kleine-koenig@pengutronix.de
    Signed-off-by: Uwe Kleine-König
    Cc: Samuel Iglesias Gonsalvez
    Cc: Jens Taprogge
    Cc: Greg Kroah-Hartman
    Signed-off-by: Andrew Morton
    Signed-off-by: Linus Torvalds

    Uwe Kleine-König
     

01 May, 2016

1 commit

  • Replace ASYNC_INITIALIZED bit in the tty_port::flags field with
    TTY_PORT_INITIALIZED bit in the tty_port::iflags field. Introduce helpers
    tty_port_set_initialized() and tty_port_initialized() to abstract
    atomic bit ops.

    Note: the transforms for test_and_set_bit() and test_and_clear_bit()
    are unnecessary as the state transitions are already mutually exclusive;
    the tty lock prevents concurrent open/close/hangup.

    Signed-off-by: Peter Hurley
    Signed-off-by: Greg Kroah-Hartman

    Peter Hurley
     

24 Sep, 2014

5 commits


19 Jul, 2014

1 commit


10 Jul, 2014

2 commits

  • The request for an IRQ handler must be done after whole configuration. This
    was not the case for this driver which request the IRQ in the middle of
    the configuration. Sometimes, it happens that something is not completely
    configured, we recieve an interrupt thus we stumble into troubles in the
    IRQ handler.

    Signed-off-by: Federico Vaga
    Acked-by: Samuel Iglesias Gonsalvez
    Signed-off-by: Greg Kroah-Hartman

    Federico Vaga
     
  • In some conditions (echo or particular sequence of special
    characters), on buffer push, the tty layer calls the write operation
    while we are holding the spinlock. This means deadlock within the same
    process on kernels version < 3.12. It seems not a problem on recent
    kernel, but the patch still valid as locking optimization.

    The protected variables by the spinlock are: xmit_buf, nb_bytes,
    pointer_read and pointer_write. So, this patch reduces the locked area
    in the IRQ handler only to these variables. Most of the code inside the
    locked area in the IRQ handler is not protected elsewhere; it means
    that it is not protected at all.

    Signed-off-by: Federico Vaga
    Acked-by: Samuel Iglesias Gonsalvez
    Signed-off-by: Greg Kroah-Hartman

    Federico Vaga
     

17 Oct, 2013

1 commit


16 Mar, 2013

2 commits


22 Feb, 2013

1 commit

  • Pull char/misc driver patches from Greg Kroah-Hartman:
    "Here's the big char/misc driver patches for 3.9-rc1.

    Nothing major here, just lots of different driver updates (mei,
    hyperv, ipack, extcon, vmci, etc.).

    All of these have been in the linux-next tree for a while."

    * tag 'char-misc-3.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc: (209 commits)
    w1: w1_therm: Add force-pullup option for "broken" sensors
    w1: ds2482: Added 1-Wire pull-up support to the driver
    vme: add missing put_device() after device_register() fails
    extcon: max8997: Use workqueue to check cable state after completing boot of platform
    extcon: max8997: Set default UART/USB path on probe
    extcon: max8997: Consolidate duplicate code for checking ADC/CHG cable type
    extcon: max8997: Set default of ADC debounce time during initialization
    extcon: max8997: Remove duplicate code related to set H/W line path
    extcon: max8997: Move defined constant to header file
    extcon: max77693: Make max77693_extcon_cable static
    extcon: max8997: Remove unreachable code
    extcon: max8997: Make max8997_extcon_cable static
    extcon: max77693: Remove unnecessary goto statement to improve readability
    extcon: max77693: Convert to devm_input_allocate_device()
    extcon: gpio: Rename filename of extcon-gpio.c according to kernel naming style
    CREDITS: update email and address of Harald Hoyer
    extcon: arizona: Use MICDET for final microphone identification
    extcon: arizona: Always take the first HPDET reading as the final one
    extcon: arizona: Clear _trig_sts bits after jack detection
    extcon: arizona: Don't HPDET magic when headphones are enabled
    ...

    Linus Torvalds
     

22 Jan, 2013

1 commit

  • Delete successive tests to the same location. The code tested the result
    of a previous allocation, that itself was already tested. It is changed to
    test the result of the most recent allocation.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @s exists@
    local idexpression y;
    expression x,e;
    @@

    *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
    { ... when forall
    return ...; }
    ... when != \(y = e\|y += e\|y -= e\|y |= e\|y &= e\|y++\|y--\|&y\)
    when != \(XT_GETPAGE(...,y)\|WMI_CMD_BUF(...)\)
    *if ( \(x == NULL\|IS_ERR(x)\|y != 0\) )
    { ... when forall
    return ...; }
    //

    Signed-off-by: Julia Lawall
    Cc: Samuel Iglesias Gonsalvez
    Signed-off-by: Greg Kroah-Hartman

    Julia Lawall
     

19 Jan, 2013

2 commits

  • The option allows you to remove TTY and compile without errors. This
    saves space on systems that won't support TTY interfaces anyway.
    bloat-o-meter output is below.

    The bulk of this patch consists of Kconfig changes adding "depends on
    TTY" to various serial devices and similar drivers that require the TTY
    layer. Ideally, these dependencies would occur on a common intermediate
    symbol such as SERIO, but most drivers "select SERIO" rather than
    "depends on SERIO", and "select" does not respect dependencies.

    bloat-o-meter output comparing our previous minimal to new minimal by
    removing TTY. The list is filtered to not show removed entries with awk
    '$3 != "-"' as the list was very long.

    add/remove: 0/226 grow/shrink: 2/14 up/down: 6/-35356 (-35350)
    function old new delta
    chr_dev_init 166 170 +4
    allow_signal 80 82 +2
    static.__warned 143 142 -1
    disallow_signal 63 62 -1
    __set_special_pids 95 94 -1
    unregister_console 126 121 -5
    start_kernel 546 541 -5
    register_console 593 588 -5
    copy_from_user 45 40 -5
    sys_setsid 128 120 -8
    sys_vhangup 32 19 -13
    do_exit 1543 1526 -17
    bitmap_zero 60 40 -20
    arch_local_irq_save 137 117 -20
    release_task 674 652 -22
    static.spin_unlock_irqrestore 308 260 -48

    Signed-off-by: Joe Millenbach
    Reviewed-by: Jamey Sharp
    Reviewed-by: Josh Triplett
    Signed-off-by: Greg Kroah-Hartman

    Joe Millenbach
     
  • There was a bug in the code when managing a GE IP-OCTAL-485 board. The RX would
    be enabled but we have a wrong state in the rx_enable flag.

    Then, if the user changes the terminal settings, RX would not be enabled again.

    Signed-off-by: Samuel Iglesias Gonsalvez
    Signed-off-by: Greg Kroah-Hartman

    Samuel Iglesias Gonsalvez
     

16 Jan, 2013

14 commits


12 Dec, 2012

1 commit

  • Pull TTY/Serial merge from Greg Kroah-Hartman:
    "Here's the big tty/serial tree set of changes for 3.8-rc1.

    Contained in here is a bunch more reworks of the tty port layer from
    Jiri and bugfixes from Alan, along with a number of other tty and
    serial driver updates by the various driver authors.

    Also, Jiri has been coerced^Wconvinced to be the co-maintainer of the
    TTY layer, which is much appreciated by me.

    All of these have been in the linux-next tree for a while.

    Signed-off-by: Greg Kroah-Hartman "

    Fixed up some trivial conflicts in the staging tree, due to the fwserial
    driver having come in both ways (but fixed up a bit in the serial tree),
    and the ioctl handling in the dgrp driver having been done slightly
    differently (staging tree got that one right, and removed both
    TIOCGSOFTCAR and TIOCSSOFTCAR).

    * tag 'tty-3.8-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty: (146 commits)
    staging: sb105x: fix potential NULL pointer dereference in mp_chars_in_buffer()
    staging/fwserial: Remove superfluous free
    staging/fwserial: Use WARN_ONCE when port table is corrupted
    staging/fwserial: Destruct embedded tty_port on teardown
    staging/fwserial: Fix build breakage when !CONFIG_BUG
    staging: fwserial: Add TTY-over-Firewire serial driver
    drivers/tty/serial/serial_core.c: clean up HIGH_BITS_OFFSET usage
    staging: dgrp: dgrp_tty.c: Audit the return values of get/put_user()
    staging: dgrp: dgrp_tty.c: Remove the TIOCSSOFTCAR ioctl handler from dgrp driver
    serial: ifx6x60: Add modem power off function in the platform reboot process
    serial: mxs-auart: unmap the scatter list before we copy the data
    serial: mxs-auart: disable the Receive Timeout Interrupt when DMA is enabled
    serial: max310x: Setup missing "can_sleep" field for GPIO
    tty/serial: fix ifx6x60.c declaration warning
    serial: samsung: add devicetree properties for non-Exynos SoCs
    serial: samsung: fix potential soft lockup during uart write
    tty: vt: Remove redundant null check before kfree.
    tty/8250 Add check for pci_ioremap_bar failure
    tty/8250 Add support for Commtech's Fastcom Async-335 and Fastcom Async-PCIe cards
    tty/8250 Add XR17D15x devices to the exar_handle_irq override
    ...

    Linus Torvalds
     

22 Nov, 2012

2 commits


17 Nov, 2012

3 commits