Eric Lee / smarc-fsl-linux-kernel

10 Sep, 2018

1 commit

  • 9cbb32610   mailbox: xgene-slimpro: Fix potential NULL pointer dereference ... Browse Code »

    commit 3512a18cbd8d09e22a790540cb9624c3c49827ba upstream.

    There is a potential execution path in which function
    platform_get_resource() returns NULL. If this happens,
    we will end up having a NULL pointer dereference.

    Fix this by replacing devm_ioremap with devm_ioremap_resource,
    which has the NULL check and the memory region request.

    This code was detected with the help of Coccinelle.

    Cc: stable@vger.kernel.org
    Fixes: f700e84f417b ("mailbox: Add support for APM X-Gene platform mailbox driver")
    Signed-off-by: Gustavo A. R. Silva
    Signed-off-by: Jassi Brar
    Signed-off-by: Greg Kroah-Hartman

    Gustavo A. R. Silva
     

29 Mar, 2017

1 commit

  • 8ce33c6ff   mailbox: constify mbox_chan_ops structures ... Browse Code »

    Check for mbox_chan_ops structures that are only stored in the ops field
    of a mbox_controller structure. This field is of type const struct
    mbox_chan_ops *, so mbox_chan_ops structures having this property can be
    declared as const.
    Done using Coccinelle:

    @r1 disable optional_qualifier @
    identifier i;
    position p;
    @@
    struct mbox_chan_ops i@p = {...};

    @ok1@
    identifier r1.i;
    struct hi6220_mbox mbox;
    struct slimpro_mbox ctx;
    position p;
    @@
    (
    mbox.controller.ops=&i@p
    |
    ctx.mb_ctrl.ops=&i@p
    )

    @bad@
    position p!={r1.p,ok1.p};
    identifier r1.i;
    @@
    i@p

    @depends on !bad disable optional_qualifier@
    identifier r1.i;
    @@
    +const
    struct mbox_chan_ops i;

    File size details:

    text data bss dec hex filename
    2310 248 0 2558 9fe drivers/mailbox/hi6220-mailbox.o
    2366 192 0 2558 9fe drivers/mailbox/hi6220-mailbox.o

    1500 248 0 1748 6d4 mailbox/mailbox-xgene-slimpro.o
    1556 192 0 1748 6d4 mailbox/mailbox-xgene-slimpro.o

    Signed-off-by: Bhumika Goyal
    Signed-off-by: Jassi Brar

    Bhumika Goyal
     

08 Apr, 2016

1 commit

04 Mar, 2016

1 commit

15 Feb, 2016

1 commit