Eric Lee / smarc-fsl-linux-kernel

12 Sep, 2017

3 commits

  • 4ce504c4e   pinctrl: sprd: fix off by one bugs ... Browse Code »

    info->groups[] has info->ngroups elements so these comparisons should be
    >= instead of >.

    Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
    Signed-off-by: Dan Carpenter
    Reviewed-by: Baolin Wang
    Signed-off-by: Linus Walleij

    Dan Carpenter
     
  • 41470c379   pinctrl: sprd: check for allocation failure ... Browse Code »

    devm_pinctrl_get() could fail with ERR_PTR(-ENOMEM) so I have added a
    check for that. I also reversed the other IS_ERR() test because it was
    a little confusing to test one way and then the opposite a couple lines
    later.

    Fixes: 41d32cfce1ae ("pinctrl: sprd: Add Spreadtrum pin control driver")
    Signed-off-by: Dan Carpenter
    Signed-off-by: Linus Walleij

    Dan Carpenter
     
  • 045b5792d   pinctrl: sprd: make three local functions static ... Browse Code »

    The functions sprd_pmx_get_function_count, sprd_pmx_get_function_name
    and sprd_pmx_get_function_groups are local to the source and do not
    need to be in global scope, so make them static.

    Cleans up sparse warnings:
    "symbol 'sprd_pmx_get_function_count' was not declared. Should it be
    static?"
    "symbol 'sprd_pmx_get_function_name' was not declared. Should it be
    static?"
    "symbol 'sprd_pmx_get_function_groups' was not declared. Should it be
    static?"

    Signed-off-by: Colin Ian King
    Signed-off-by: Linus Walleij

    Colin Ian King
     

31 Aug, 2017

1 commit