18 Aug, 2017
7 commits
-
dqi_flags modifications are protected by dq_data_lock. However the
modifications in vfs_load_quota_inode() and in mark_info_dirty() were
not which could lead to corruption of dqi_flags. Since modifications to
dqi_flags are rare, this is hard to observe in practice but in theory it
could happen. Fix the problem by always using dq_data_lock for
protection.Signed-off-by: Jan Kara
-
Push down acquisition of dqio_sem into ->read_file_info() callback. This
is for consistency with other operations and it also allows us to get
rid of an ugliness in OCFS2.Reviewed-by: Andreas Dilger
Signed-off-by: Jan Kara -
Push down acquisition of dqio_sem into ->write_file_info() callback.
Mostly for consistency with other operations.Reviewed-by: Andreas Dilger
Signed-off-by: Jan Kara -
The old quota quota format has fixed offset in quota file based on ID so
there's no locking needed against concurrent modifications of the file
(locking against concurrent IO on the same dquot is still provided by
dq_lock).Reviewed-by: Andreas Dilger
Signed-off-by: Jan Kara -
Push down acquisition of dqio_sem into ->write_dqblk() callback. It will
allow quota formats to decide whether they need it or not.Reviewed-by: Andreas Dilger
Signed-off-by: Jan Kara -
The old quota format has fixed offset in quota file based on ID so
there's no locking needed against concurrent modifications of the file
(locking against concurrent IO on the same dquot is still provided by
dq_lock).Reviewed-by: Andreas Dilger
Signed-off-by: Jan Kara -
Push down acquisition of dqio_sem into ->read_dqblk() callback. It will
allow quota formats to decide whether they need it or not.Reviewed-by: Andreas Dilger
Signed-off-by: Jan Kara
30 Jan, 2015
1 commit
-
Currently maximum space limit quota format supports is in blocks however
since we store space limits in bytes, this is somewhat confusing. So
store the maximum limit in bytes as well. Also rename the field to match
the new unit and related inode field to match the new naming scheme.Reviewed-by: Christoph Hellwig
Signed-off-by: Jan Kara
18 Sep, 2012
1 commit
-
Change struct dquot dq_id to a struct kqid and remove the now
unecessary dq_type.Make minimal changes to dquot, quota_tree, quota_v1, quota_v2, ext3,
ext4, and ocfs2 to deal with the change in quota structures and
signatures. The ocfs2 changes are larger than most because of the
extensive tracing throughout the ocfs2 quota code that prints out
dq_id.quota_tree.c:get_index is modified to take a struct kqid instead of a
qid_t because all of it's callers pass in dquot->dq_id and it allows
me to introduce only a single conversion.The rest of the changes are either just replacing dq_type with dq_id.type,
adding conversions to deal with the change in type and occassionally
adding qid_eq to allow quota id comparisons in a user namespace safe way.Cc: Mark Fasheh
Cc: Joel Becker
Cc: Jan Kara
Cc: Andrew Morton
Cc: Andreas Dilger
Cc: Theodore Tso
Signed-off-by: "Eric W. Biederman"
21 Jul, 2010
1 commit
-
The current quota error message doesn't always print the disk name, so
it is hard to identify the "bad" disk when quota error happens.This patch changes the standardized quota error message to print out disk name
and function name. It also uses a combination of cpp macro and inline function
to provide better type checking and to lower the text size of the message.[Jan Kara: Export __quota_error]
Signed-off-by: Jiaying Zhang
Signed-off-by: Jan Kara
22 May, 2010
1 commit
-
Quota stats is mostly writable data structure. Let's alloc percpu
bucket for each value.NOTE: dqstats_read() function is racy against dqstats_{inc,dec}
and may return inconsistent value. But this is ok since absolute
accuracy is not required.Signed-off-by: Dmitry Monakhov
Signed-off-by: Jan Kara
10 Dec, 2009
1 commit
-
Signed-off-by: Alexey Dobriyan
Signed-off-by: Jan Kara
26 Mar, 2009
2 commits
-
Wrap long lines, remove assignments from conditions, rewrite two
overcomplicated for loops.Signed-off-by: Jan Kara
-
Quota subsystem has more and more files. It's time to create a dir for it.
Signed-off-by: Jan Kara