04 Jun, 2019
1 commit
-
Add a new section for UAPI structure and helper definitions
in kernel docbook.Suggested-by: Daniel Vetter
Signed-off-by: Uma Shankar
Signed-off-by: Daniel Vetter
Link: https://patchwork.freedesktop.org/patch/msgid/1559567330-25182-2-git-send-email-uma.shankar@intel.com
03 Jun, 2019
1 commit
-
With Eric's patch
commit ba6e798ecf320716780bb6a6088a8d17dcba1d49
Author: Eric Anholt
Date: Wed Apr 24 11:56:17 2019 -0700drm/doc: Document expectation that userspace review looks at kernel uAPI.
there's been concerns raised that we expect userspace people to do
in-depth kernel patch review. That's not reasonable, same way kernel
people can't review all the userspace we have. Try to clarify
expectations a bit more.Cc: Eric Anholt
Cc: Pekka Paalanen
Cc: contact@emersion.fr
Cc: wayland-devel@lists.freedesktop.org
Acked-by: Eric Anholt
Reviewed-by: Simon Ser
Reviewed-by: Pekka Paalanen
Signed-off-by: Daniel Vetter
Link: https://patchwork.freedesktop.org/patch/msgid/20190521084849.27452-1-daniel.vetter@ffwll.ch
17 May, 2019
2 commits
-
The point of this review process is that userspace using the new uAPI
can actually live with the uAPI being provided, and it's hard to know
that without having actually looked into a kernel patch yourself.Signed-off-by: Eric Anholt
Suggested-by: Daniel Vetter
Link: https://patchwork.freedesktop.org/patch/msgid/20190424185617.16865-2-eric@anholt.net
Reviewed-by: Daniel Vetter -
I was trying to figure out if it was permissible to merge the Mesa
side of V3D's CSD support yet while it's in drm-misc-next but not
drm-next, and developers on #dri-devel IRC had differing opinions of
what the requirement was.v2: Restrict to just drm-next or drm-misc-next on airlied's request.
Signed-off-by: Eric Anholt
Link: https://patchwork.freedesktop.org/patch/msgid/20190424220638.16222-1-eric@anholt.net
Reviewed-by: Daniel Vetter
07 Feb, 2019
1 commit
-
Compared to the RFC[1] no changes to the patch itself, but igt moved
forward a lot:- gitlab CI builds with: reduced configs/libraries, arm cross build
and a sysroot build (should address all the build/cross platform
concerns raised in the RFC discussions).- tests reorganized into subdirectories so that the i915-gem tests
don't clog the main/shared tests directory anymore- quite a few more non-intel people contributing/reviewing/committing
igt tests patches.I think this addresses all the concerns raised in the RFC discussions,
and assuming there's enough Acks and no new issues that pop up, we can
go ahead with this.v2:
- Use "should" (in the usual RFC sense) to make it clear that in the
end this is all up to reviewer's discretion, as usual (Jani).
- Also in the title s/mandatory/strongly suggested/ (me)
- Make it clear we're not going to block features if a testcase is not
feasible, given hw and state of igt, both having some good gaps in
what can be tested (Harry, Eric, Sean, ...).1: https://patchwork.kernel.org/patch/10648851/
Cc: Petri Latvala
Cc: Arkadiusz Hiler
Cc: Liviu Dudau
Cc: Sean Paul
Cc: Eric Anholt
Cc: Alex Deucher
Cc: Dave Airlie
Cc: Daniel Stone
Cc: "Wentland, Harry"
Cc: Brian Starkey
Reviewed-by: Eric Anholt (v1)
Acked-by: Petri Latvala
Acked-by: Arkadiusz Hiler
Acked-by: Sean Paul
Acked-by: "Wentland, Harry"
Signed-off-by: Daniel Vetter
Acked-by: Liviu Dudau
Acked-by: Jani Nikula
Acked-by: Brian Starkey
Acked-by: Tomi Valkeinen
Acked-by: Boris Brezillon
Acked-by: Alex Deucher
Acked-by: Dave Airlie
Link: https://patchwork.freedesktop.org/patch/msgid/20190128172258.9585-1-daniel.vetter@ffwll.ch
30 Dec, 2018
1 commit
-
Pull documentation update from Jonathan Corbet:
"A fairly normal cycle for documentation stuff. We have a new document
on perf security, more Italian translations, more improvements to the
memory-management docs, improvements to the pathname lookup
documentation, and the usual array of smaller fixes.As is often the case, there are a few reaches outside of
Documentation/ to adjust kerneldoc comments"* tag 'docs-5.0' of git://git.lwn.net/linux: (38 commits)
docs: improve pathname-lookup document structure
configfs: fix wrong name of struct in documentation
docs/mm-api: link slab_common.c to "The Slab Cache" section
slab: make kmem_cache_create{_usercopy} description proper kernel-doc
doc:process: add links where missing
docs/core-api: make mm-api.rst more structured
x86, boot: documentation whitespace fixup
Documentation: devres: note checking needs when converting
doc:it: add some process/* translations
doc:it: fixes in process/1.Intro
Documentation: convert path-lookup from markdown to resturctured text
Documentation/admin-guide: update admin-guide index.rst
Documentation/admin-guide: introduce perf-security.rst file
scripts/kernel-doc: Fix struct and struct field attribute processing
Documentation: dev-tools: Fix typos in index.rst
Correct gen_init_cpio tool's documentation
Document /proc/pid PID reuse behavior
Documentation: update path-lookup.md for parallel lookups
Documentation: Use "while" instead of "whilst"
dmaengine: Add mailing list address to the documentation
...
08 Nov, 2018
1 commit
-
Trivial fix to a spelling mistake of the error access name EACCESS,
rename to EACCESSigned-off-by: Colin Ian King
Signed-off-by: Jonathan Corbet
24 Oct, 2018
1 commit
-
We recently bikeshedded this to a different flavour, but forgot to
update the recommendations.Cc: Chris Wilson
Cc: Ville Syrjälä
Reviewed-by: Chris Wilson
Signed-off-by: Daniel Vetter
Link: https://patchwork.freedesktop.org/patch/msgid/20181019084311.23836-1-daniel.vetter@ffwll.ch
23 Aug, 2017
1 commit
-
We're not super-consistent about these, but I think it's worth to
document at least the commmon patterns.v2:
- Add a not about ENOTTY (it's just a confusing name, but used
exactly what it's meant for in DRM) (Chris).
- Unconfuse the text for ENODEV (Daniel)
- Move text undert the IOCTL heading (Chris).
- typosCc: Daniel Stone
Cc: Joonas Lahtinen
Cc: Chris Wilson
Cc: "Zhang, Tina"
Reviewed-by: Chris Wilson
Signed-off-by: Daniel Vetter
Link: https://patchwork.freedesktop.org/patch/msgid/20170818174328.6386-1-daniel.vetter@ffwll.ch
20 Jun, 2017
1 commit
-
I spotted a markup issue, plus adding the descriptions in drm_driver.
Plus a few more links while at it.I'm still mildly unhappy with the split between fops and ioctls, but I
still think having the ioctls in the uapi chapter makes more sense. Oh
well ...v2: Rebase.
v3: Move misplace hunk to the right patch.
Cc: Stefan Agner
Acked-by: Thierry Reding
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/20170531092045.3950-1-daniel.vetter@ffwll.ch
05 Apr, 2017
2 commits
-
Also unify/merge with the existing stuff.
I was a bit torn where to put this, but in the end I decided to put
all the ioctl/sysfs/debugfs stuff into drm-uapi.rst. That means we
have a bit a split with the other uapi related stuff used internally,
like drm_file.[hc], but I think overall this makes more sense.If it's too confusing we can always add more cross-links to make it
more discoverable. But the auto-sprinkling of links kernel-doc already
does seems sufficient.Also for prettier docs and more cross-links, switch the internal
defines over to an enum, as usual.v2: Update kerneldoc fro drm_compat_ioctl too (caught by 0day), plus a
bit more drive-by polish.v3: Fix typo, spotted by xerpi on irc (Sergi).
v4: Add missing space in comment (Neil).
Cc: Sergi Granell
Reviewed-by: Neil Armstrong
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/20170404095304.17599-4-daniel.vetter@ffwll.ch -
- remove docs for internal func, doesn't add value
- add short overview snippet instead explaining that drivers don't
have to bother themselves with reg/unreg concerns
- drop the ttm comment about drmP.h, drmP.h is disappearing ...Reviewed-by: Neil Armstrong
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/20170404095304.17599-2-daniel.vetter@ffwll.ch
24 Mar, 2017
2 commits
-
I've decided to not document drm_debugfs_remove_files, it's on the way
out.The biggest part is a huge todo.rst entry with what all should be
improved.v2: Nits from Gabriel.
Cc: Gabriel Krisman Bertazi
Reviewed-by: Gabriel Krisman Bertazi
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/20170322205401.24897-1-daniel.vetter@ffwll.ch -
This was missed in Tomeu's patch. Also remove the kerneldoc for the
internal function, we don't document that in general.While at it word-smith the docs slightly for more clarity.
Cc: Tomeu Vizoso
Reviewed-by: Tomeu Vizoso
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/20170322083617.13361-4-daniel.vetter@ffwll.ch
14 Mar, 2017
1 commit
-
Well, mostly drm_file.h, and clean up all related things:
- I didnt' figure out the difference between preclose and postclose.
The existing explanation in drm-internals.rst didn't convince me,
since it's also really outdated - we clean up pending DRM events in
the core nowadays. I put a FIXME in for the future.- Another FIXME is to have a macro for default fops.
- Lots of links all around, main areas are to tie the overview in
drm_file.c more into the callbacks in struct drm_device, and the
other is to link render/primary node code to the right sections in
drm-uapi.rst.- Also moved the open/close stuff to drm_drv.h from drm-internals.rst,
seems like the better place for that information. Since that section
was rather outdated this amounted to full-on rewrite.A big missing piece here is some overview graph, but I think better to
wait with that one until drm_device and drm_driver are also fully
documented.v2: Nits from Sean.
Reviewed-by: Sean Paul
Reviewed-by: Liviu Dudau
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/20170308141257.12119-12-daniel.vetter@ffwll.ch
30 Dec, 2016
1 commit
-
- Remove the outdated hunk about driver documentation which somehow
got misplaced here in the split-up.- Collect all the testing&validation stuff together and give the CRC
section a heading for prettier output.Cc: Tomeu Vizoso
Cc: Jani Nikula
Reviewed-by: David Herrmann
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/1483044517-5770-1-git-send-email-daniel.vetter@ffwll.ch
17 Oct, 2016
1 commit
-
Adds files and directories to debugfs for controlling and reading frame
CRCs, per CRTC:dri/0/crtc-0/crc
dri/0/crtc-0/crc/control
dri/0/crtc-0/crc/dataDrivers can implement the set_crc_source callback() in drm_crtc_funcs to
start and stop generating frame CRCs and can add entries to the output
by calling drm_crtc_add_crc_entry.v2:
- Lots of good fixes suggested by Thierry.
- Added documentation.
- Changed the debugfs layout.
- Moved to allocate the entries circular queue once when frame
generation gets enabled for the first time.
v3:
- Use the control file just to select the source, and start and stop
capture when the data file is opened and closed, respectively.
- Make variable the number of CRC values per entry, per source.
- Allocate entries queue each time we start capturing as now there
isn't a fixed number of CRC values per entry.
- Store the frame counter in the data file as a 8-digit hex number.
- For sources that cannot provide useful frame numbers, place
XXXXXXXX in the frame field.v4:
- Build only if CONFIG_DEBUG_FS is enabled.
- Use memdup_user_nul.
- Consolidate calculation of the size of an entry in a helper.
- Add 0x prefix to hex numbers in the data file.
- Remove unnecessary snprintf and strlen usage in read callback.v5:
- Made the crcs array in drm_crtc_crc_entry fixed-size
- Lots of other smaller improvements suggested by Emil Velikovv7:
- Move definition of drm_debugfs_crtc_crc_add to drm_internal.hv8:
- Call debugfs_remove_recursive when we fail to create the minor
devicev9:
- Register the debugfs directory for a crtc from
drm_crtc_register_all()v10:
- Don't let debugfs failures interrupt CRTC registration (Emil
Velikov)v11:
- Remove extra brace that broke compilation. Sorry!Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
Acked-by: Benjamin Gaignard
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/1475767268-14379-3-git-send-email-tomeu.vizoso@collabora.com
01 Sep, 2016
1 commit
-
Also provide some pointers for building IGT as some kernel hackers might
not be that familiar with building stuff on Linux distros.Signed-off-by: Tomeu Vizoso
Cc: Daniel Vetter
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/1472715695-19812-1-git-send-email-tomeu.vizoso@collabora.com
24 Aug, 2016
1 commit
-
Everyone knows them, except all the new folks joining from the ARM
side haven't lived through all the pain of the past years and are
entirely surprised when I raise this. Definitely time to document
this.Last time this was a big discussion was about 6 years ago, when qcom
tried to land a kernel driver without userspace. Dave Airlie made the
rules really clear:http://airlied.livejournal.com/73115.html
This write-up here is essentially what I've put into a presentation a
while ago, which was also reviewed by Dave:http://blog.ffwll.ch/2015/05/gfx-kernel-upstreaming-requirements.html
v2: Fix typos Eric&Rob spotted.
v3: Nitpick from Jani.
Cc: Dave Airlie
Cc: Oded Gabbay
Cc: Russell King
Cc: Tomi Valkeinen
Cc: Eric Anholt
Cc: Thomas Hellstrom
Cc: Sinclair Yeh
Cc: Lucas Stach
Cc: Benjamin Gaignard
Cc: Mark Yao
Cc: Laurent Pinchart
Cc: Ben Skeggs
Cc: Rob Clark
Cc: CK Hu
Cc: Xinliang Liu
Cc: Philipp Zabel
Cc: Stefan Agner
Cc: Inki Dae
Cc: Maxime Ripard
Cc: Boris Brezillon
Cc: Jani Nikula
Cc: Daniel Vetter
Cc: Thierry Reding
Cc: Christian König
Cc: Alex Deucher
Cc: Gerd Hoffmann
Cc: Brian Starkey
Cc: Liviu Dudau
Cc: Alexey Brodkin
Acked-by: Dave Airlie
Reviewed-by: Rob Clark
Reviewed-by: Christian König
Reviewed-by: Eric Anholt
Reviewed-by: Jani Nikula
Signed-off-by: Daniel Vetter
Signed-off-by: Dave Airlie
16 Aug, 2016
1 commit
-
- Move the common vtable stuff to the top
- Move "Tile Group" to a more appropriate heading level
- Throw away the old intro for the crtc helpers (it's entirely stale,
e.g. helpers have become modular years ago), and replace it with a
general intro about the motivation behind helpers.
- Reorder helpers to group them together a bit better, and explain
that grouping in the intro.
- Make sure the introductory DOC section is always first.v2:
- Remove bogus files accidentally added (Sean).
- Spelling fixes (Sean).Cc: Sean Paul
Reviewed-by: Sean Paul
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/1471034937-651-2-git-send-email-daniel.vetter@ffwll.ch
22 Jun, 2016
2 commits
-
Also extract drm_auth.h for nicer grouping.
v2: Nuke the other comments since they don't really explain a lot, and
within the drm core we generally only document functions exported to
drivers: The main audience for these docs are driver writers.v3: Limit the exposure of drm_master internals by only including
drm_auth.h where it is neede (Chris).v4: Spelling polish (Emil).
Cc: Chris Wilson
Reviewed-by: Chris Wilson
Reviewed-by: Emil Velikov
Signed-off-by: Daniel Vetter -
We already have a fallback in place to fill out the unique from
dev->unique, which is set to something reasonable in drm_dev_alloc.Which means we only need to have a special set_busid for pci devices,
to be able to care the backwards compat code for drm 1.1 around, which
libdrm still needs.While developing and testing this patch things blew up in really
interesting ways, and the code is rather confusing in naming things
between the kernel code, ioctl #defines and libdrm. For the next brave
dragon slayer, document all this madness properly in the userspace
interface section of gpu.tmpl.v2: Make drm_dev_set_unique static and update kerneldoc.
v3: Entire rewrite, plus document what's going on for posterity in the
gpu docbook uapi section.v4: Drop accidental amdgpu hunk (Emil).
v5: Drop accidental omapdrm vblank counter change (Emil).
v6: Rebase on top of the sphinx conversion.
Cc: Gustavo Padovan
Cc: Emil Velikov
Tested-by: Gustavo Padovan (virt_gpu)
Reviewed-by: Emil Velikov
Signed-off-by: Daniel Vetter
21 Jun, 2016
2 commits
-
While splitting the document up, the headings "shifted" from what pandoc
generated. Use the following order for headings for consistency:==============
Document title
==============First
=====Second
------Third
~~~~~Leave the lower level headings as they are; I think those are less
important. Although RST doesn't mandate a specific order ("Rather than
imposing a fixed number and order of section title adornment styles, the
order enforced will be the order as encountered."), having the higher
levels the same overall makes it easier to follow the documents.[I'm sort of kind of writing the recommendation for docs-next in the
mean time, but this order seems sensible, and is what I'm proposing.]Signed-off-by: Jani Nikula
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/126f42734defac6cbb8496a481d58db7b38461dd.1466506505.git.jani.nikula@intel.com -
Make the gpu documentation easier to manage by splitting to separate
files. Again, this is just the split, no real edits.Signed-off-by: Jani Nikula
Signed-off-by: Daniel Vetter
Link: http://patchwork.freedesktop.org/patch/msgid/bd2b599b5105c28c8f05923005e6cc9b7efa7fc1.1466506505.git.jani.nikula@intel.com
