Eric Lee / smarc-fsl-linux-kernel

29 Aug, 2010

25 commits

28 Aug, 2010

11 commits

  • 7a28826ac   ALSA: pcm: add more format names ... Browse Code »

    There were some new formats added in commit 15c0cee6c809 "ALSA: pcm:
    Define G723 3-bit and 5-bit formats". That commit increased
    SNDRV_PCM_FORMAT_LAST as well. My concern is that there are a couple
    places which do:

    for (i = 0; i < SNDRV_PCM_FORMAT_LAST; i++) {
    if (dummy->pcm_hw.formats & (1ULL << i))
    snd_iprintf(buffer, " %s", snd_pcm_format_name(i));
    }

    I haven't tested these but it looks like if "i" were equal to
    SNDRV_PCM_FORMAT_G723_24 or higher then we might read past the end of
    the array.

    Signed-off-by: Dan Carpenter
    Signed-off-by: Takashi Iwai

    Dan Carpenter
     
  • 3182c8a72   sound: oss: fix uninitialized spinlock ... Browse Code »

    The spinlock lock in sound_timer.c is used without initialization.

    Signed-off-by: Akinobu Mita
    Signed-off-by: Takashi Iwai

    Akinobu Mita
     
  • 60f1deb59   ALSA: asihpi - Return hw error directly from oustream_write. ... Browse Code »

    If hw error is ignored, status is updated with invalid info.

    Signed-off-by: Eliot Blennerhassett
    Signed-off-by: Takashi Iwai

    Eliot Blennerhassett
     
  • c34186ed0   net/ipv4: Eliminate kstrdup memory leak ... Browse Code »

    The string clone is only used as a temporary copy of the argument val
    within the while loop, and so it should be freed before leaving the
    function. The call to strsep, however, modifies clone, so a pointer to the
    front of the string is kept in saved_clone, to make it possible to free it.

    The sematic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    //
    @r exists@
    local idexpression x;
    expression E;
    identifier l;
    statement S;
    @@

    *x= \(kasprintf\|kstrdup\)(...);
    ...
    if (x == NULL) S
    ... when != kfree(x)
    when != E = x
    if (...) {

    * return ...;
    }
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: David S. Miller

    Julia Lawall
     
  • 92b4678ef   fsnotify: drop two useless bools in the fnsotify main loop ... Browse Code »

    The fsnotify main loop has 2 bools which indicated if we processed the
    inode or vfsmount mark in that particular pass through the loop. These
    bool can we replaced with the inode_group and vfsmount_group variables
    and actually make the code a little easier to understand.

    Signed-off-by: Eric Paris

    Eric Paris
     
  • f72adfd54   fsnotify: fix list walk order ... Browse Code »

    Marks were stored on the inode and vfsmonut mark list in order from
    highest memory address to lowest memory address. The code to walk those
    lists thought they were in order from lowest to highest with
    unpredictable results when trying to match up marks from each. It was
    possible that extra events would be sent to userspace when inode
    marks ignoring events wouldn't get matched with the vfsmount marks.

    This problem only affected fanotify when using both vfsmount and inode
    marks simultaneously.

    Signed-off-by: Eric Paris

    Eric Paris
     
  • a2f13ad0b   fanotify: Return EPERM when a process is not privileged ... Browse Code »

    The appropriate error code when privileged operations are denied is
    EPERM, not EACCES.

    Signed-off-by: Andreas Gruenbacher
    Signed-off-by: Eric Paris

    Andreas Gruenbacher
     
  • 0fb85621d   fanotify: resize pid and reorder structure ... Browse Code »

    resize pid and reorder the fanotify_event_metadata so it is naturally
    aligned and we can work towards dropping the packed attributed

    Signed-off-by: Tvrtko Ursulin
    Cc: Andreas Dilger
    Signed-off-by: Eric Paris

    Tvrtko Ursulin
     
  • 9e5610a99   Blackfin: bf52x/bf54x boards: drop unused nand page size ... Browse Code »

    Now that the driver for the Blackfin on-chip NFC no longer uses/respects
    the page_size from the platform resources (figures out the needs on the
    fly), drop it from the platform resources. This fixes some build errors
    since the defines no longer exists.

    Signed-off-by: Barry Song
    Signed-off-by: Mike Frysinger

    Barry Song
     
  • ac0a5042b   Blackfin: punt duplicate SPORT MMR defines ... Browse Code »

    The common bfin_sport.h header now has unified definitions of these, so
    stop polluting the global namespace.

    Signed-off-by: Mike Frysinger

    Mike Frysinger
     
  • 708fafb3c   ASoC: soc-core: fix debugfs_pop_time file permissions ... Browse Code »

    I think this is a typo, debugfs_pop_time should not be executable.

    Signed-off-by: Axel Lin
    Acked-by: Liam Girdwood
    Signed-off-by: Mark Brown

    Axel Lin
     

27 Aug, 2010

4 commits

  • 93c3fe40c   eCryptfs: Fix encrypted file name lookup regression ... Browse Code »

    Fixes a regression caused by 21edad32205e97dc7ccb81a85234c77e760364c8

    When file name encryption was enabled, ecryptfs_lookup() failed to use
    the encrypted and encoded version of the upper, plaintext, file name
    when performing a lookup in the lower file system. This made it
    impossible to lookup existing encrypted file names and any newly created
    files would have plaintext file names in the lower file system.

    https://bugs.launchpad.net/ecryptfs/+bug/623087

    Signed-off-by: Tyler Hicks

    Tyler Hicks
     
  • 7371a3820   ecryptfs: properly mark init functions ... Browse Code »

    Some ecryptfs init functions are not prefixed by __init and thus not
    freed after initialization. This patch saved about 1kB in ecryptfs
    module.

    Signed-off-by: Jerome Marchand
    Signed-off-by: Tyler Hicks

    Jerome Marchand
     
  • f137f1507   fs/ecryptfs: Return -ENOMEM on memory allocation failure ... Browse Code »

    In this code, 0 is returned on memory allocation failure, even though other
    failures return -ENOMEM or other similar values.

    A simplified version of the semantic match that finds this problem is as
    follows: (http://coccinelle.lip6.fr/)

    //
    @@
    expression ret;
    expression x,e1,e2,e3;
    @@

    ret = 0
    ... when != ret = e1
    *x = \(kmalloc\|kcalloc\|kzalloc\)(...)
    ... when != ret = e2
    if (x == NULL) { ... when != ret = e3
    return ret;
    }
    //

    Signed-off-by: Julia Lawall
    Signed-off-by: Tyler Hicks

    Julia Lawall
     
  • 766211e74   ARM: S5PV310: Fix on Secondary CPU startup ... Browse Code »

    Following occurs on boot message without this patch.
    CPU1: processor failed to boot
    Brought up 1 CPUs
    SMP: Total of 1 processors activated...

    This patch adds SYSRAM mapping for fixing Secondary CPU startup.
    CPU1: Booted secondary processor
    Brought up 2 CPUs
    SMP: Total of 2 processors activated...

    Signed-off-by: Changhwan Youn
    Signed-off-by: Kukjin Kim

    Changhwan Youn