05 Jul, 2011

6 commits

  • Linus Torvalds
     
  • * git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi-rc-fixes-2.6: (277 commits)
    [SCSI] isci: fix checkpatch errors
    isci: Device reset should request sas_phy_reset(phy, true)
    isci: pare back error messsages
    isci: cleanup silicon revision detection
    isci: merge scu_unsolicited_frame.h into unsolicited_frame_control.h
    isci: merge sata.[ch] into request.c
    isci: kill 'get/set' macros
    isci: retire scic_sds_ and scic_ prefixes
    isci: unify isci_host and scic_sds_controller
    isci: unify isci_remote_device and scic_sds_remote_device
    isci: unify isci_port and scic_sds_port
    isci: fix scic_sds_remote_device_terminate_requests
    isci: unify isci_phy and scic_sds_phy
    isci: unify isci_request and scic_sds_request
    isci: rename / clean up scic_sds_stp_request
    isci: preallocate requests
    isci: combine request flags
    isci: unify can_queue tracking on the tci_pool, uplevel tag assignment
    isci: Terminate dev requests on FIS err bit rx in NCQ
    isci: fix frame received locking
    ...

    Linus Torvalds
     
  • * 'at91/fixes' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/linux-2.6-arm-soc:
    AT91: Change nand buswidth logic to match hardware default configuration
    at91: Use "pclk" as con_id on at91cap9 and at91rm9200
    at91: fix udc, ehci and mmc clock device name for cap9/9g45/9rl
    atmel_serial: fix internal port num
    at91: fix at91_set_serial_console: use platform device id

    Linus Torvalds
     
  • …l/git/lethal/fbdev-3.x

    * 'fbdev-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/lethal/fbdev-3.x:
    vesafb: fix memory leak
    fbdev: amba: Link fb device to its parent
    fsl-diu-fb: remove check for pixel clock ranges
    udlfb: Correct sub-optimal resolution selection.
    hecubafb: add module_put on error path in hecubafb_probe()
    sm501fb: fix section mismatch warning
    gx1fb: Fix section mismatch warnings
    fbdev: sh_mobile_meram: Correct pointer check for YCbCr chroma plane

    Linus Torvalds
     
  • Commits 71c29bd5c235 ("IB/uverbs: Add devnode method to set path/mode")
    and c3af0980ce01 ("IB: Add devnode methods to cm_class and umad_class")
    added devnode methods that set the mode.

    However, these methods don't check for a NULL mode, and so we get a
    crash when unloading modules because devtmpfs_delete_node() calls
    device_get_devnode() with mode == NULL.

    Add the missing checks.

    Signed-off-by: Goldwyn Rodrigues
    [ Also fix cm.c. - Roland ]
    Signed-off-by: Roland Dreier
    Signed-off-by: Linus Torvalds

    Goldwyn Rodrigues
     
  • The recently modified nand buswitth configuration is not aligned with
    board reality: the double footprint on boards is always populated with 8bits
    buswidth nand flashes.
    So we have to consider that without particular configuration the 8bits
    buswidth is selected by default.
    Moreover, the previous logic was always using !board_have_nand_8bit(), we
    change it to a simpler: board_have_nand_16bit().

    Signed-off-by: Nicolas Ferre
    Tested-by: Ludovic Desroches
    Signed-off-by: Arnd Bergmann

    Nicolas Ferre
     

04 Jul, 2011

6 commits


03 Jul, 2011

28 commits

  • Add some CPU series IDs and links to the Fam12h datasheets.

    Signed-off-by: Clemens Ladisch
    Signed-off-by: Jean Delvare

    Clemens Ladisch
     
  • It's Nehemiah, not Nemiah.

    Signed-off-by: Jean Delvare
    Acked-by: Guenter Roeck

    Jean Delvare
     
  • The F71869A is almost the same as the F71869F/E, except that it has
    the normal number of temp and pwm zones for a F71882FG derived chip,
    rather then the limited number of the F71869F/E.

    Signed-off-by: Hans de Goede
    Tested-by: Max Baldwin
    Acked-by: Guenter Roeck
    Signed-off-by: Jean Delvare

    Hans de Goede
     
  • Signed-off-by: Hans de Goede
    Signed-off-by: Jean Delvare

    Hans de Goede
     
  • Handle errors on 8-bit register reads and writes too. Also use likely
    and unlikely to make the functions faster on success.

    Signed-off-by: Jean Delvare
    Acked-by: Guenter Roeck

    Jean Delvare
     
  • The hard_reset parameter passed to the LLDD in the direct-attached
    phy control case allows the LLDD to filter link failure events
    while the direct-attached device reset is executing.

    Signed-off-by: Jeff Skirvin
    Signed-off-by: Dan Williams

    Jeff Skirvin
     
  • The messages emitted from task.c and some from request.c likely
    duplicate (in a less undertandable way) what is reported by the
    midlayer.

    Signed-off-by: Dan Williams

    Dan Williams
     
  • Perform checking per-pci device (even though all systems will only have
    1 pci device in this generation), and delete support for silicon that
    does not report a proper revision (i.e. A0).

    Reported-by: Christoph Hellwig
    Signed-off-by: Dan Williams

    Dan Williams
     
  • Does not need its own file.

    Signed-off-by: Dan Williams

    Dan Williams
     
  • Undo some needless separation.

    Signed-off-by: Dan Williams

    Dan Williams
     
  • Most of these simple dereference macros are longer than their open coded
    equivalent. Deleting enum sci_controller_mode is thrown in for good
    measure.

    Reported-by: Christoph Hellwig
    Signed-off-by: Dan Williams

    Dan Williams
     
  • The distinction between scic_sds_ scic_ and sci_ are no longer relevant
    so just unify the prefixes on sci_. The distinction between isci_ and
    sci_ is historically significant, and useful for comparing the old
    'core' to the current Linux driver. 'sci_' represents the former core as
    well as the routines that are closer to the hardware and protocol than
    their 'isci_' brethren. sci == sas controller interface.

    Also unwind the 'sds1' out of the parameter structs.

    Reported-by: Christoph Hellwig
    Signed-off-by: Dan Williams

    Dan Williams
     
  • Remove the distinction between these two implementations and unify on
    isci_host (local instances named ihost). Hmmm, we had two
    'oem_parameters' instances, one was unused... nice.

    Reported-by: Christoph Hellwig
    Signed-off-by: Dan Williams

    Dan Williams
     
  • Remove the distinction between these two implementations and unify on
    isci_remote_device (local instances named idev).

    Reported-by: Christoph Hellwig
    Signed-off-by: Dan Williams

    Dan Williams
     
  • Remove the distinction between these two implementations and unify on
    isci_port (local instances named iport). The duplicate '->owning_port' and
    '->isci_port' in both isci_phy and isci_remote_device will be fixed in a later
    patch... this is just the straightforward rename/unification.

    Reported-by: Christoph Hellwig
    Signed-off-by: Dan Williams

    Dan Williams
     
  • Commit 0815632 "isci: unify remote_device stop_handlers" introduced the
    possibility that not all requests get terminated if we reach the
    request_count. Now that we properly reference count devices we don't
    need this self-defense and can do the straightforward scan of all active
    requests.

    Reported-by: Jeff Skirvin
    Acked-by: Jeff Skirvin
    Signed-off-by: Dan Williams

    Dan Williams
     
  • They are one in the same object so remove the distinction. The near
    duplicate fields (owning_port, and isci_port) will be cleaned up
    after the scic_sds_port isci_port unification.

    Reported-by: Christoph Hellwig
    Signed-off-by: Dan Williams

    Dan Williams
     
  • They are one in the same object so remove the distinction. The near
    duplicate fields (owning_controller, and isci_host) will be cleaned up
    after the scic_sds_contoller isci_host unification.

    Reported-by: Christoph Hellwig
    Signed-off-by: Dan Williams

    Dan Williams
     
  • * Rename scic_sds_stp_request to isci_stp_request
    * Remove the unused fields and union indirection

    Reported-by: Christoph Hellwig
    Signed-off-by: Dan Williams

    Dan Williams
     
  • the dma_pool interface is optimized for object_size << page_size which
    is not the case with isci_request objects and the dma_pool routines show
    up in the top of the profile.

    The old io_request_table which tracked whether tci slots were in-flight
    or not is replaced with an IREQ_ACTIVE flag per request.

    Signed-off-by: Dan Williams

    Dan Williams
     
  • Combine three bools into one unsigned long 'flags'. Doesn't increase the
    request size due to packing. (to do: optimize the structure layout).

    Signed-off-by: Dan Williams

    Dan Williams
     
  • The tci_pool tracks our outstanding command slots which are also the 'index'
    portion of our tags. Grabbing the tag early in ->lldd_execute_task let's us
    drop the isci_host_can_queue() and ->was_tag_assigned_by_user infrastructure.
    ->was_tag_assigned_by_user required the task context to be duplicated in
    request-local buffer. With the tci established early we can build the
    task_context directly into its final location and skip a memcpy.

    With the task context buffer at a known address at request construction we
    have the opportunity/obligation to also fix sgl handling. This rework feels
    like it belongs in another patch but the sgl handling and task_context are too
    intertwined.
    1/ fix the 'ab' pair embedded in the task context to point to the 'cd' pair in
    the task context (previously we were prematurely linking to the staging
    buffer).
    2/ fix the broken iteration of pio sgls that assumes all sgls are relative to
    the request, and does a dangerous looking reverse lookup of physical
    address to virtual address.

    Signed-off-by: Dan Williams

    Dan Williams
     
  • When the remote device transitions to a not-ready state because of
    an NCQ error condition, all outstanding requests to that device
    are terminated and completed to libsas on the normal path. The
    device then waits for a READ LOG EXT command to issue on the task
    management path.

    Signed-off-by: Jeff Skirvin
    Signed-off-by: Dan Williams

    Jeff Skirvin
     
  • Updates to the frame_rcvd before need to be atomic with respect to when
    they are evaluated by libsas.

    Signed-off-by: Dan Williams

    Dan Williams
     
  • scu_index is a parameter of isci_parse_eom_parameters and is an index
    in controller table. There is a check: scu_index > SCI_MAX_CONTROLLERS
    which is insufficient and should be: scu_index >= SCI_MAX_CONTROLLERS.
    scu_index is used as an index in the table which size is
    SCI_MAX_CONTROLLERS.

    Signed-off-by: Maciej Patelczyk
    Signed-off-by: Dan Williams

    Maciej Patelczyk
     
  • 1/ fix the timeout for wait_for_completion_timeout
    2/ In the tmf timeout case we need to wait for our termination callback
    3/ Once the request is successfully started it will be freed according to the
    normal lifetime for requests.

    Signed-off-by: Dan Williams

    Dan Williams
     
  • Instead of duplicating the smp request buffer reuse the one provided by
    libsas. This future proofs the driver to support arbitrarily large smp
    requests, and shrinks the request structure size by ~700 bytes.

    Signed-off-by: Dan Williams

    Dan Williams
     
  • One bug and a cleanup:
    1/ Fix cases where we were unmapping invalid addresses (smp requests were
    being unmapped)

    [ 604.662770] ------------[ cut here ]------------
    [ 604.668026] WARNING: at lib/dma-debug.c:800 check_unmap+0x418/0x740()
    [ 604.675315] Hardware name: SandyBridge Platform
    [ 604.680465] isci 0000:03:00.0: DMA-API: device driver tries to free an invalid DMA memory address

    2/ The unmap routine is too large to be an inline function, and
    isci_request_io_request_get_next_sge is unused.

    Signed-off-by: Dan Williams

    Dan Williams