kobject: Transmit return value of call_usermodehelper() to caller

kobject_uevent_env() drops the return value of call_usermodehelper(). It will make upper caller, such as dm_send_uevents(), to lose error information. BTW, Previously kobject_uevent_env() transmitted return of call_usermodehelper() to callers, but commit 5f123fbd80f4f788554636f02bf73e40f914e0d6 "[PATCH] merge kobject_uevent and kobject_hotplug" removed it. Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com> Cc: Kay Sievers <kay.sievers@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

kobject: Transmit return value of call_usermodehelper() to caller
kobject_uevent_env() drops the return value of call_usermodehelper(). It will make upper caller, such as dm_send_uevents(), to lose error information. BTW, Previously kobject_uevent_env() transmitted return of call_usermodehelper() to callers, but commit 5f123fbd80f4f788554636f02bf73e40f914e0d6 "[PATCH] merge kobject_uevent and kobject_hotplug" removed it. Signed-off-by: Wang Chen <wangchen@cn.fujitsu.com> Cc: Kay Sievers <kay.sievers@suse.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Wang Chen · Greg Kroah-Hartman
1 parent 83c79b55f0
Showing 1 changed file with 2 additions and 1 deletions Side-by-side Diff
lib/kobject_uevent.c
@@ -245,7 +245,8 @@
 		if (retval)
 			goto exit;
  
-		call_usermodehelper(argv[0], argv, env->envp, UMH_WAIT_EXEC);
+		retval = call_usermodehelper(argv[0], argv,
+					     env->envp, UMH_WAIT_EXEC);
 	}
  
 exit:
...	...	@@ -245,7 +245,8 @@
245	245	if (retval)
246	246	goto exit;
247	247
248		- call_usermodehelper(argv[0], argv, env->envp, UMH_WAIT_EXEC);
	248	+ retval = call_usermodehelper(argv[0], argv,
	249	+ env->envp, UMH_WAIT_EXEC);
249	250	}
250	251
251	252	exit: