Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit 0df05be2d81ba21663c611c50515b9e54a1372b3

Authored by Lucas Stach
Committed by Greg Kroah-Hartman
1 parent 9a42a8a458

PCI: designware: Reject MSI-X IRQs 

commit 19c5392eb1c1e81188e898400c0e8258827eb160 upstream.

The DesignWare PCIe MSI hardware does not support MSI-X IRQs.  Setting
those up failed as a side effect of a bug which was fixed by 91f8ae823f2b
("PCI: designware: Setup and clear exactly one MSI at a time").

Now that this bug is fixed, MSI-X IRQs need to be rejected explicitly;
otherwise devices trying to use them may end up with incorrectly working
interrupts.

Fixes: 91f8ae823f2b ("PCI: designware: Setup and clear exactly one MSI at a time")
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 3 additions and 0 deletions Side-by-side Diff

drivers/pci/host/pcie-designware.c
Diff comments   View file @ 0df05be
... ... @@ -283,6 +283,9 @@
283 283 struct msi_msg msg;
284 284 struct pcie_port *pp = sys_to_pcie(pdev->bus->sysdata);
285 285  
  286 + if (desc->msi_attrib.is_msix)
  287 + return -EINVAL;
  288 +
286 289 irq = assign_irq(1, desc, &pos);
287 290 if (irq < 0)
288 291 return irq;