Commit 0e116227a01580acf47437adba3afadf21b6bd5f

Authored by Tao Ma
Committed by Mark Fasheh
1 parent adee14b2e1

ocfs2: Fix a bug in direct IO read.

ocfs2 will become read-only if we try to read the bytes which pass
the end of i_size. This can be easily reproduced by following steps:
1. mkfs a ocfs2 volume with bs=4k cs=4k and nosparse.
2. create a small file(say less than 100 bytes) and we will create the file
   which is allocated 1 cluster.
3. read 8196 bytes from the kernel using O_DIRECT which exceeds the limit.
4. The ocfs2 volume becomes read-only and dmesg shows:
OCFS2: ERROR (device sda13): ocfs2_direct_IO_get_blocks:
Inode 66010 has a hole at block 1
File system is now read-only due to the potential of on-disk corruption.
Please run fsck.ocfs2 once the file system is unmounted.

So suppress the ERROR message.

Signed-off-by: Tao Ma <tao.ma@oracle.com>
Signed-off-by: Mark Fasheh <mfasheh@suse.com>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -594,7 +594,7 @@
594 594 goto bail;
595 595 }
596 596  
597   - if (!ocfs2_sparse_alloc(OCFS2_SB(inode->i_sb)) && !p_blkno) {
  597 + if (!ocfs2_sparse_alloc(OCFS2_SB(inode->i_sb)) && !p_blkno && create) {
598 598 ocfs2_error(inode->i_sb,
599 599 "Inode %llu has a hole at block %llu\n",
600 600 (unsigned long long)OCFS2_I(inode)->ip_blkno,