Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit 0f363b250b15af0f218bb2876d101fe5cd413f8b

Authored by Peter Zijlstra
Committed by Ingo Molnar
1 parent 300176af03
Exists in ti-lsk-linux-4.1.y and in 10 other branches dlt-processor-sdk-linux-03.00.00.04, processor-sdk-linux-02.00.01, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04

x86: Fix off-by-one in instruction decoder 

Stephane reported that the PEBS fixup was broken by the recent commit to
the instruction decoder. The thing had an off-by-one which resulted in
not being able to decode the last instruction and always bail.

Reported-by: Stephane Eranian <eranian@google.com>
Fixes: 6ba48ff46f76 ("x86: Remove arbitrary instruction size limit in instruction decoder")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: stable@vger.kernel.org # 3.18
Cc: <ak@linux.intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Liang Kan <kan.liang@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Jim Keniston <jkenisto@us.ibm.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Link: http://lkml.kernel.org/r/20141216104614.GV3337@twins.programming.kicks-ass.net
Signed-off-by: Ingo Molnar <mingo@kernel.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -28,7 +28,7 @@
28 28  
29 29 /* Verify next sizeof(t) bytes can be on the same instruction */
30 30 #define validate_next(t, insn, n) \
31   - ((insn)->next_byte + sizeof(t) + n < (insn)->end_kaddr)
  31 + ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr)
32 32  
33 33 #define __get_next(t, insn) \
34 34 ({ t r = *(t*)insn->next_byte; insn->next_byte += sizeof(t); r; })