Commit 11e043b53c3d4fbcbf91761b8dfd885da6fc8eff
Committed by
Bryan Wu
1 parent
00d1955285
Exists in
master
and in
16 other branches
leds: replace list_for_each with list_for_each_entry
Use the more convenient macro. Signed-off-by: ZHAO Gang <gamerh2o@gmail.com> Signed-off-by: Bryan Wu <cooloney@gmail.com>
Showing 1 changed file with 4 additions and 11 deletions Side-by-side Diff
drivers/leds/led-triggers.c
... | ... | @@ -242,18 +242,14 @@ |
242 | 242 | void led_trigger_event(struct led_trigger *trig, |
243 | 243 | enum led_brightness brightness) |
244 | 244 | { |
245 | - struct list_head *entry; | |
245 | + struct led_classdev *led_cdev; | |
246 | 246 | |
247 | 247 | if (!trig) |
248 | 248 | return; |
249 | 249 | |
250 | 250 | read_lock(&trig->leddev_list_lock); |
251 | - list_for_each(entry, &trig->led_cdevs) { | |
252 | - struct led_classdev *led_cdev; | |
253 | - | |
254 | - led_cdev = list_entry(entry, struct led_classdev, trig_list); | |
251 | + list_for_each_entry(led_cdev, &trig->led_cdevs, trig_list) | |
255 | 252 | led_set_brightness(led_cdev, brightness); |
256 | - } | |
257 | 253 | read_unlock(&trig->leddev_list_lock); |
258 | 254 | } |
259 | 255 | EXPORT_SYMBOL_GPL(led_trigger_event); |
260 | 256 | |
... | ... | @@ -264,16 +260,13 @@ |
264 | 260 | int oneshot, |
265 | 261 | int invert) |
266 | 262 | { |
267 | - struct list_head *entry; | |
263 | + struct led_classdev *led_cdev; | |
268 | 264 | |
269 | 265 | if (!trig) |
270 | 266 | return; |
271 | 267 | |
272 | 268 | read_lock(&trig->leddev_list_lock); |
273 | - list_for_each(entry, &trig->led_cdevs) { | |
274 | - struct led_classdev *led_cdev; | |
275 | - | |
276 | - led_cdev = list_entry(entry, struct led_classdev, trig_list); | |
269 | + list_for_each_entry(led_cdev, &trig->led_cdevs, trig_list) { | |
277 | 270 | if (oneshot) |
278 | 271 | led_blink_set_oneshot(led_cdev, delay_on, delay_off, |
279 | 272 | invert); |