Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit 12dac5fcf5ec156f9f056aff1a8cbed04fde5538

Authored by Ioan-Adrian Ratiu
Committed by Greg Kroah-Hartman
1 parent 301681d600
Exists in smarct4x-processor-sdk-04.01.00.06 and in 1 other branch smarct3x-processor-sdk-04.01.00.06

ALSA: usb-audio: test EP_FLAG_RUNNING at urb completion 

[ Upstream commit 13a6c8328e6056932dc680e447d4c5e8ad9add17 ]

Testing EP_FLAG_RUNNING in snd_complete_urb() before running the completion
logic allows us to save a few cpu cycles by returning early, skipping the
pending urb in case the stream was stopped; the stop logic handles the urb
and sets the completion callbacks to NULL.

Signed-off-by: Ioan-Adrian Ratiu <adi@adirat.com>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 3 additions and 0 deletions Side-by-side Diff

sound/usb/endpoint.c
Diff comments   View file @ 12dac5f
... ... @@ -384,6 +384,9 @@
384 384 if (unlikely(atomic_read(&ep->chip->shutdown)))
385 385 goto exit_clear;
386 386  
  387 + if (unlikely(!test_bit(EP_FLAG_RUNNING, &ep->flags)))
  388 + goto exit_clear;
  389 +
387 390 if (usb_pipeout(ep->pipe)) {
388 391 retire_outbound_urb(ep, ctx);
389 392 /* can be stopped during retire callback */