Commit 14e9d5730adfca26452b3a2838a80af6950556f5

Authored by Eric W. Biederman
Committed by Linus Torvalds
1 parent c97beb4710

[PATCH] pid: Properly detect orphaned process groups in exit_notify

In commit 0475ac0845f9295bc5f69af45f58dff2c104c8d1 when converting the
orphaned process group handling to use struct pid I made a small
mistake.  I accidentally replaced an == with a !=.

Besides just being a dumb thing to do apparently this has a bad side
effect.  The improper orphaned process group detection causes kwin to
die after a suspend/resume cycle.

I'm amazed this patch has been around as long as it has without anyone
else noticing something funny going on.

And the following people deserve credit for spotting and helping
to reproduce this.

Thanks to: Sid Boyce <g3vbv@blueyonder.co.uk>
Thanks to: "Michael Wu"

Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -790,7 +790,7 @@
790 790  
791 791 pgrp = task_pgrp(tsk);
792 792 if ((task_pgrp(t) != pgrp) &&
793   - (task_session(t) != task_session(tsk)) &&
  793 + (task_session(t) == task_session(tsk)) &&
794 794 will_become_orphaned_pgrp(pgrp, tsk) &&
795 795 has_stopped_jobs(pgrp)) {
796 796 __kill_pgrp_info(SIGHUP, SEND_SIG_PRIV, pgrp);