Commit 16c55b038033d8f6f7601996dfae44399666d9ab

Authored by Tejun Heo
Committed by Jeff Garzik
1 parent 7f9992a231

libata: implement BROKEN_HPA horkage and apply it to affected drives

Some drives choke on READ_NATIVE_MAX_ADDRESS[_EXT].  Implement
ATA_HORKAGE_BROKEN_HPA and apply it to affected drives.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

Showing 2 changed files with 9 additions and 3 deletions Side-by-side Diff

drivers/ata/libata-core.c
... ... @@ -1911,8 +1911,9 @@
1911 1911 dev->flags |= ATA_DFLAG_FLUSH_EXT;
1912 1912 }
1913 1913  
1914   - if (ata_id_hpa_enabled(dev->id))
1915   - dev->n_sectors = ata_hpa_resize(dev);
  1914 + if (!(dev->horkage & ATA_HORKAGE_BROKEN_HPA) &&
  1915 + ata_id_hpa_enabled(dev->id))
  1916 + dev->n_sectors = ata_hpa_resize(dev);
1916 1917  
1917 1918 /* config NCQ */
1918 1919 ata_dev_config_ncq(dev, ncq_desc, sizeof(ncq_desc));
... ... @@ -3795,7 +3796,11 @@
3795 3796 { "ST9160821AS", "3.CLF", ATA_HORKAGE_NONCQ, },
3796 3797 { "SAMSUNG HD401LJ", "ZZ100-15", ATA_HORKAGE_NONCQ, },
3797 3798  
3798   - /* Devices with NCQ limits */
  3799 + /* devices which puke on READ_NATIVE_MAX */
  3800 + { "HDS724040KLSA80", "KFAOA20N", ATA_HORKAGE_BROKEN_HPA, },
  3801 + { "WDC WD3200JD-00KLB0", "WD-WCAMR1130137", ATA_HORKAGE_BROKEN_HPA },
  3802 + { "WDC WD2500JD-00HBB0", "WD-WMAL71490727", ATA_HORKAGE_BROKEN_HPA },
  3803 + { "MAXTOR 6L080L4", "A93.0500", ATA_HORKAGE_BROKEN_HPA },
3799 3804  
3800 3805 /* End Marker */
3801 3806 { }
include/linux/libata.h
... ... @@ -303,6 +303,7 @@
303 303 ATA_HORKAGE_NODMA = (1 << 1), /* DMA problems */
304 304 ATA_HORKAGE_NONCQ = (1 << 2), /* Don't use NCQ */
305 305 ATA_HORKAGE_MAX_SEC_128 = (1 << 3), /* Limit max sects to 128 */
  306 + ATA_HORKAGE_BROKEN_HPA = (1 << 4), /* Broken HPA */
306 307 };
307 308  
308 309 enum hsm_task_states {