Commit 1801ead6f421db1272d7479ebc9467ccdf5eb90a

Authored by Dmitry Osipenko
Committed by Greg Kroah-Hartman
1 parent a4cb200d87

ARM: tegra: Re-add removed SoC id macro to tegra_resume()

commit e4a680099a6e97ecdbb81081cff9e4a489a4dc44 upstream.

Commit d127e9c ("ARM: tegra: make tegra_resume can work with current and later
chips") removed tegra_get_soc_id macro leaving used cpu register corrupted after
branching to v7_invalidate_l1() and as result causing execution of unintended
code on tegra20. Possibly it was expected that r6 would be SoC id func argument
since common cpu reset handler is setting r6 before branching to tegra_resume(),
but neither tegra20_lp1_reset() nor tegra30_lp1_reset() aren't setting r6
register before jumping to resume function. Fix it by re-adding macro.

Fixes: d127e9c (ARM: tegra: make tegra_resume can work with current and later chips)
Reviewed-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

arch/arm/mach-tegra/reset-handler.S
... ... @@ -51,6 +51,7 @@
51 51 THUMB( it ne )
52 52 bne cpu_resume @ no
53 53  
  54 + tegra_get_soc_id TEGRA_APB_MISC_BASE, r6
54 55 /* Are we on Tegra20? */
55 56 cmp r6, #TEGRA20
56 57 beq 1f @ Yes