Commit 1f8cdae43929d32e3706c314eb2a302dc3683fba
Committed by
Linus Torvalds
Linus Torvalds
1 parent
97922b5462
Exists in
master
and in
20 other branches
markup_oops.pl: fix error with x86
When I try to use markup_oops.pl in x86, I always get:
cat 1 | perl markup_oops.pl ./vmlinux
objdump: --start-address: bad number: NaN
No matching code found
This is because in line:
if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/[a-f0-9]/) {
$function = $1;
$func_offset = $2;
}
$func_offset will get a number like "0x2"
But in follow code:
my $decodestart = Math::BigInt->from_hex("0x$target") -
Math::BigInt->from_hex("0x$func_offset");
It add other ox to ox2. Then this value will be set to NaN.
So I made a small patch to fix it.
Signed-off-by: Hui Zhu <teawater@gmail.com>
Acked-by: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
scripts/markup_oops.pl
| ... | ... | @@ -154,7 +154,7 @@ |
| 154 | 154 | if ($line =~ /RIP: 0010:\[\<([a-z0-9]+)\>\]/) { |
| 155 | 155 | $target = $1; |
| 156 | 156 | } |
| 157 | - if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+(0x[0-9a-f]+)\/0x[a-f0-9]/) { | |
| 157 | + if ($line =~ /EIP is at ([a-zA-Z0-9\_]+)\+0x([0-9a-f]+)\/0x[a-f0-9]/) { | |
| 158 | 158 | $function = $1; |
| 159 | 159 | $func_offset = $2; |
| 160 | 160 | } |