Commit 23ab274ddf83931ecc21968d11c773a2a972e462

Authored by Benjamin Poirier
Committed by Greg Kroah-Hartman
1 parent 5f70407192

scsi: bfa: Increase requested firmware version to 3.2.5.1

[ Upstream commit 2d1148f0f45079d25a0fa0d67e4fdb2a656d12fb ]

bna & bfa firmware version 3.2.5.1 was submitted to linux-firmware on
Feb 17 19:10:20 2015 -0500 in 0ab54ff1dc ("linux-firmware: Add QLogic BR
Series Adapter Firmware").

bna was updated to use the newer firmware on Feb 19 16:02:32 2015 -0500 in
3f307c3d70 ("bna: Update the Driver and Firmware Version")

bfa was not updated. I presume this was an oversight but it broke support
for bfa+bna cards such as the following
	04:00.0 Fibre Channel [0c04]: Brocade Communications Systems, Inc.
		1010/1020/1007/1741 10Gbps CNA [1657:0014] (rev 01)
	04:00.1 Fibre Channel [0c04]: Brocade Communications Systems, Inc.
		1010/1020/1007/1741 10Gbps CNA [1657:0014] (rev 01)
	04:00.2 Ethernet controller [0200]: Brocade Communications Systems,
		Inc. 1010/1020/1007/1741 10Gbps CNA [1657:0014] (rev 01)
	04:00.3 Ethernet controller [0200]: Brocade Communications Systems,
		Inc. 1010/1020/1007/1741 10Gbps CNA [1657:0014] (rev 01)

Currently, if the bfa module is loaded first, bna fails to probe the
respective devices with
[  215.026787] bna: QLogic BR-series 10G Ethernet driver - version: 3.2.25.1
[  215.043707] bna 0000:04:00.2: bar0 mapped to ffffc90001fc0000, len 262144
[  215.060656] bna 0000:04:00.2: initialization failed err=1
[  215.073893] bna 0000:04:00.3: bar0 mapped to ffffc90002040000, len 262144
[  215.090644] bna 0000:04:00.3: initialization failed err=1

Whereas if bna is loaded first, bfa fails with
[  249.592109] QLogic BR-series BFA FC/FCOE SCSI driver - version: 3.2.25.0
[  249.610738] bfa 0000:04:00.0: Running firmware version is incompatible with the driver version
[  249.833513] bfa 0000:04:00.0: bfa init failed
[  249.833919] scsi host6: QLogic BR-series FC/FCOE Adapter, hwpath: 0000:04:00.0 driver: 3.2.25.0
[  249.841446] bfa 0000:04:00.1: Running firmware version is incompatible with the driver version
[  250.045449] bfa 0000:04:00.1: bfa init failed
[  250.045962] scsi host7: QLogic BR-series FC/FCOE Adapter, hwpath: 0000:04:00.1 driver: 3.2.25.0

Increase bfa's requested firmware version. Also increase the driver
version.  I only tested that all of the devices probe without error.

Reported-by: Tim Ehlers <tehlers@gwdg.de>
Signed-off-by: Benjamin Poirier <bpoirier@suse.com>
Acked-by: Rasesh Mody <rasesh.mody@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 2 changed files with 4 additions and 4 deletions Side-by-side Diff

drivers/scsi/bfa/bfad.c
... ... @@ -64,9 +64,9 @@
64 64 u32 bfi_image_cb_size, bfi_image_ct_size, bfi_image_ct2_size;
65 65 u32 *bfi_image_cb, *bfi_image_ct, *bfi_image_ct2;
66 66  
67   -#define BFAD_FW_FILE_CB "cbfw-3.2.3.0.bin"
68   -#define BFAD_FW_FILE_CT "ctfw-3.2.3.0.bin"
69   -#define BFAD_FW_FILE_CT2 "ct2fw-3.2.3.0.bin"
  67 +#define BFAD_FW_FILE_CB "cbfw-3.2.5.1.bin"
  68 +#define BFAD_FW_FILE_CT "ctfw-3.2.5.1.bin"
  69 +#define BFAD_FW_FILE_CT2 "ct2fw-3.2.5.1.bin"
70 70  
71 71 static u32 *bfad_load_fwimg(struct pci_dev *pdev);
72 72 static void bfad_free_fwimg(void);
drivers/scsi/bfa/bfad_drv.h
... ... @@ -58,7 +58,7 @@
58 58 #ifdef BFA_DRIVER_VERSION
59 59 #define BFAD_DRIVER_VERSION BFA_DRIVER_VERSION
60 60 #else
61   -#define BFAD_DRIVER_VERSION "3.2.25.0"
  61 +#define BFAD_DRIVER_VERSION "3.2.25.1"
62 62 #endif
63 63  
64 64 #define BFAD_PROTO_NAME FCPI_NAME