Commit 2860aaba4dc87fa43c08724434b87a8650f3bff5
Committed by
Linus Torvalds
1 parent
3c29e03d91
Exists in
master
and in
20 other branches
[PATCH] rcu: Avoid kthread_stop on invalid pointer if rcutorture reader startup fails
rcu_torture_init kmallocs the array of reader threads, then creates each one with kthread_run, cleaning up with rcu_torture_cleanup if this fails. rcu_torture_cleanup calls kthread_stop on any non-NULL pointer in the array; however, any readers after the one that failed to start up will have invalid pointers, not null pointers. Avoid this by using kzalloc instead. Signed-off-by: Josh Triplett <josh@freedesktop.org> Acked-by: Paul E. McKenney <paulmck@us.ibm.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff
kernel/rcutorture.c
... | ... | @@ -780,7 +780,7 @@ |
780 | 780 | writer_task = NULL; |
781 | 781 | goto unwind; |
782 | 782 | } |
783 | - reader_tasks = kmalloc(nrealreaders * sizeof(reader_tasks[0]), | |
783 | + reader_tasks = kzalloc(nrealreaders * sizeof(reader_tasks[0]), | |
784 | 784 | GFP_KERNEL); |
785 | 785 | if (reader_tasks == NULL) { |
786 | 786 | VERBOSE_PRINTK_ERRSTRING("out of memory"); |