Commit 35a5fe695b07ae899510ad76fdf0aeaef85fe951

Authored by Bjorn Helgaas
Committed by Greg Kroah-Hartman
1 parent 89c86a64cd

kobject: remove kset from sysfs immediately in kset_unregister()

There's no "unlink from sysfs" interface for ksets, so I think callers of
kset_unregister() expect the kset to be removed from sysfs immediately,
without waiting for the last reference to be released.

This patch makes the sysfs removal happen immediately, so the caller may
create a new kset with the same name as soon as kset_unregister() returns.
Without this, every caller has to call "kobject_del(&kset->kobj)" first
unless it knows it will never create a new kset with the same name.

This sometimes shows up on module unload and reload, where the reload fails
because it tries to create a kobject with the same name as one from the
original load that still exists.  CONFIG_DEBUG_KOBJECT_RELEASE=y makes this
problem easier to hit.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 2 changed files with 5 additions and 1 deletions Side-by-side Diff

Documentation/kobject.txt
... ... @@ -342,7 +342,10 @@
342 342  
343 343 When you are finished with the kset, call:
344 344 void kset_unregister(struct kset *kset);
345   -to destroy it.
  345 +to destroy it. This removes the kset from sysfs and decrements its reference
  346 +count. When the reference count goes to zero, the kset will be released.
  347 +Because other references to the kset may still exist, the release may happen
  348 +after kset_unregister() returns.
346 349  
347 350 An example of using a kset can be seen in the
348 351 samples/kobject/kset-example.c file in the kernel tree.
... ... @@ -855,6 +855,7 @@
855 855 {
856 856 if (!k)
857 857 return;
  858 + kobject_del(&k->kobj);
858 859 kobject_put(&k->kobj);
859 860 }
860 861