Commit 381be25458524f9bcec5bf1e40c82d1ebb408475
Committed by
Linus Torvalds
1 parent
1a80ba8827
Exists in
master
and in
20 other branches
[PATCH] ext3: sparse fixes
Fix warnings from sparse due to un-declared functions that should either have a header file or have been declared static fs/ext2/bitmap.c:14:15: warning: symbol 'ext2_count_free' was not declared. Should it be static? fs/ext2/namei.c:92:15: warning: symbol 'ext2_get_parent' was not declared. Should it be static? fs/ext3/bitmap.c:15:15: warning: symbol 'ext3_count_free' was not declared. Should it be static? fs/ext3/namei.c:1013:15: warning: symbol 'ext3_get_parent' was not declared. Should it be static? fs/ext3/xattr.c:214:1: warning: symbol 'ext3_xattr_block_get' was not declared. Should it be static? fs/ext3/xattr.c:358:1: warning: symbol 'ext3_xattr_block_list' was not declared. Should it be static? fs/ext3/xattr.c:630:1: warning: symbol 'ext3_xattr_block_find' was not declared. Should it be static? fs/ext3/xattr.c:863:1: warning: symbol 'ext3_xattr_ibody_find' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben-linux@fluff.org> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Showing 8 changed files with 29 additions and 6 deletions Side-by-side Diff
fs/ext3/balloc.c
fs/ext3/bitmap.c
fs/ext3/bitmap.h
fs/ext3/ialloc.c
fs/ext3/namei.c
fs/ext3/namei.h
fs/ext3/super.c
... | ... | @@ -36,9 +36,12 @@ |
36 | 36 | #include <linux/namei.h> |
37 | 37 | #include <linux/quotaops.h> |
38 | 38 | #include <linux/seq_file.h> |
39 | + | |
39 | 40 | #include <asm/uaccess.h> |
41 | + | |
40 | 42 | #include "xattr.h" |
41 | 43 | #include "acl.h" |
44 | +#include "namei.h" | |
42 | 45 | |
43 | 46 | static int ext3_load_journal(struct super_block *, struct ext3_super_block *); |
44 | 47 | static int ext3_create_journal(struct super_block *, struct ext3_super_block *, |
... | ... | @@ -615,7 +618,6 @@ |
615 | 618 | #endif |
616 | 619 | }; |
617 | 620 | |
618 | -struct dentry *ext3_get_parent(struct dentry *child); | |
619 | 621 | static struct export_operations ext3_export_ops = { |
620 | 622 | .get_parent = ext3_get_parent, |
621 | 623 | }; |
fs/ext3/xattr.c
... | ... | @@ -210,7 +210,7 @@ |
210 | 210 | return cmp ? -ENODATA : 0; |
211 | 211 | } |
212 | 212 | |
213 | -int | |
213 | +static int | |
214 | 214 | ext3_xattr_block_get(struct inode *inode, int name_index, const char *name, |
215 | 215 | void *buffer, size_t buffer_size) |
216 | 216 | { |
... | ... | @@ -354,7 +354,7 @@ |
354 | 354 | return buffer_size - rest; |
355 | 355 | } |
356 | 356 | |
357 | -int | |
357 | +static int | |
358 | 358 | ext3_xattr_block_list(struct inode *inode, char *buffer, size_t buffer_size) |
359 | 359 | { |
360 | 360 | struct buffer_head *bh = NULL; |
... | ... | @@ -626,7 +626,7 @@ |
626 | 626 | struct buffer_head *bh; |
627 | 627 | }; |
628 | 628 | |
629 | -int | |
629 | +static int | |
630 | 630 | ext3_xattr_block_find(struct inode *inode, struct ext3_xattr_info *i, |
631 | 631 | struct ext3_xattr_block_find *bs) |
632 | 632 | { |
... | ... | @@ -859,7 +859,7 @@ |
859 | 859 | struct ext3_iloc iloc; |
860 | 860 | }; |
861 | 861 | |
862 | -int | |
862 | +static int | |
863 | 863 | ext3_xattr_ibody_find(struct inode *inode, struct ext3_xattr_info *i, |
864 | 864 | struct ext3_xattr_ibody_find *is) |
865 | 865 | { |