Eric Lee / smarc-ti-linux-kernel | Embedian Git Server

Commit 3836a03d978e68b0ae00d3589089343c998cd4ff

Authored by Eric Paris 2010-03-10 11:23:01 +0800

Committed by Linus Torvalds 2010-03-13 08:25:23 +0800

anon_inodes: mark the anon inode private

Inotify was switched to use anon_inode instead of its own private filesystem
which only had one inode in commit c44dcc56d2b5c7 "switch inotify_user to
anon_inode"

The problem with this is that now the inotify inode is not a distinct inode
which can be managed by LSMs.  userspace tools which use inotify were allowed
to use the inotify inode but may not have had permission to do read/write type
operations on the anon_inode.  After looking at the anon_inode and its users
it looks like the best solution is to just mark the anon_inode as S_PRIVATE
so the security system will ignore it.

Signed-off-by: Eric Paris <eparis@redhat.com>
Acked-by: James Morris <jmorris@namei.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

fs/anon_inodes.c

fs/anon_inodes.c

Diff comments View file @ 3836a03

...	...	@@ -209,6 +209,7 @@
209	209	inode->i_mode = S_IRUSR \| S_IWUSR;
210	210	inode->i_uid = current_fsuid();
211	211	inode->i_gid = current_fsgid();
	212	+ inode->i_flags \|= S_PRIVATE;
212	213	inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
213	214	return inode;
214	215	}