Eric Lee / smarc-ti-linux-kernel

6
Download as
Browse Code ยป

Commit 38c1c2e44bacb37efd68b90b3f70386a8ee370ee

Authored by Liu Bo
Committed by Chris Mason
1 parent a3c108950d
Exists in ti-lsk-linux-4.1.y and in 10 other branches dlt-processor-sdk-linux-03.00.00.04, processor-sdk-linux-02.00.01, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04

Btrfs: fix crash on endio of reading corrupted block 

The crash is

------------[ cut here ]------------
kernel BUG at fs/btrfs/extent_io.c:2124!
[...]
Workqueue: btrfs-endio normal_work_helper [btrfs]
RIP: 0010:[<ffffffffa02d6055>]  [<ffffffffa02d6055>] end_bio_extent_readpage+0xb45/0xcd0 [btrfs]

This is in fact a regression.

It is because we forgot to increase @offset properly in reading corrupted block,
so that the @offset remains, and this leads to checksum errors while reading
left blocks queued up in the same bio, and then ends up with hiting the above
BUG_ON.

Reported-by: Chris Murphy <lists@colorremedies.com>
Signed-off-by: Liu Bo <bo.li.liu@oracle.com>
Signed-off-by: Chris Mason <clm@fb.com>

Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff

fs/btrfs/extent_io.c
Diff comments   View file @ 38c1c2e
... ... @@ -2532,6 +2532,7 @@
2532 2532 test_bit(BIO_UPTODATE, &bio->bi_flags);
2533 2533 if (err)
2534 2534 uptodate = 0;
  2535 + offset += len;
2535 2536 continue;
2536 2537 }
2537 2538 }