Eric Lee / smarc-ti-linux-kernel

31
Download as
Browse Code ยป

Commit 3b74c73f8d6f053f422e85fce955b61fb181cfe7

Authored by Felipe Balbi
Committed by Greg Kroah-Hartman
1 parent f3c7364982
Exists in master and in 13 other branches dlt-processor-sdk-linux-03.00.00.04, processor-sdk-linux-02.00.01, smarc-ti-linux-3.15.y, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04, ti-linux-3.15.y, ti-lsk-linux-4.1.y

usb: gadget: inode: switch over to memdup_user() 

This patch fixes the following Coccinelle warning:

drivers/usb/gadget/inode.c:442:8-15: WARNING \
	opportunity for memdup_user

Signed-off-by: Felipe Balbi <balbi@ti.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 3 additions and 6 deletions Side-by-side Diff

drivers/usb/gadget/inode.c
Diff comments   View file @ 3b74c73
... ... @@ -439,12 +439,10 @@
439 439 /* FIXME writebehind for O_NONBLOCK and poll(), qlen = 1 */
440 440  
441 441 value = -ENOMEM;
442   - kbuf = kmalloc (len, GFP_KERNEL);
443   - if (!kbuf)
  442 + kbuf = memdup_user(buf, len);
  443 + if (!kbuf) {
  444 + value = PTR_ERR(kbuf);
444 445 goto free1;
445   - if (copy_from_user (kbuf, buf, len)) {
446   - value = -EFAULT;
447   - goto free1;
448 446 }
449 447  
450 448 value = ep_io (data, kbuf, len);
... ... @@ -452,7 +450,6 @@
452 450 data->name, len, (int) value);
453 451 free1:
454 452 mutex_unlock(&data->lock);
455   - kfree (kbuf);
456 453 return value;
457 454 }
458 455