Commit 3c606d35fe9766ede86a45273a628b320be13b45

Authored by Johannes Weiner
Committed by Tejun Heo
1 parent 97bf6af1f9

cgroup: prevent mount hang due to memory controller lifetime

Since b2052564e66d ("mm: memcontrol: continue cache reclaim from
offlined groups"), re-mounting the memory controller after using it is
very likely to hang.

The cgroup core assumes that any remaining references after deleting a
cgroup are temporary in nature, and synchroneously waits for them, but
the above-mentioned commit has left-over page cache pin its css until
it is reclaimed naturally.  That being said, swap entries and charged
kernel memory have been doing the same indefinite pinning forever, the
bug is just more likely to trigger with left-over page cache.

Reparenting kernel memory is highly impractical, which leaves changing
the cgroup assumptions to reflect this: once a controller has been
mounted and used, it has internal state that is independent from mount
and cgroup lifetime.  It can be unmounted and remounted, but it can't
be reconfigured during subsequent mounts.

Don't offline the controller root as long as there are any children,
dead or alive.  A remount will no longer wait for these old references
to drain, it will simply mount the persistent controller state again.

Reported-by: "Suzuki K. Poulose" <Suzuki.Poulose@arm.com>
Reported-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Tejun Heo <tj@kernel.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -1909,7 +1909,7 @@
1909 1909 *
1910 1910 * And don't kill the default root.
1911 1911 */
1912   - if (css_has_online_children(&root->cgrp.self) ||
  1912 + if (!list_empty(&root->cgrp.self.children) ||
1913 1913 root == &cgrp_dfl_root)
1914 1914 cgroup_put(&root->cgrp);
1915 1915 else