Commit 48c348b09c6b35b1cf6f2125d1d4fd7c962dd79d
Committed by
J. Bruce Fields
J. Bruce Fields
1 parent
15d176c195
NFSD: Fix bad using of return value from qword_get
Signed-off-by: Kinglong Mee <kinglongmee@gmail.com> Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Showing 1 changed file with 3 additions and 3 deletions Side-by-side Diff
fs/nfsd/nfs4idmap.c
| ... | ... | @@ -368,7 +368,7 @@ |
| 368 | 368 | { |
| 369 | 369 | struct ent ent, *res; |
| 370 | 370 | char *buf1; |
| 371 | - int error = -EINVAL; | |
| 371 | + int len, error = -EINVAL; | |
| 372 | 372 | |
| 373 | 373 | if (buf[buflen - 1] != '\n') |
| 374 | 374 | return (-EINVAL); |
| ... | ... | @@ -392,8 +392,8 @@ |
| 392 | 392 | IDMAP_TYPE_USER : IDMAP_TYPE_GROUP; |
| 393 | 393 | |
| 394 | 394 | /* Name */ |
| 395 | - error = qword_get(&buf, buf1, PAGE_SIZE); | |
| 396 | - if (error <= 0 || error >= IDMAP_NAMESZ) | |
| 395 | + len = qword_get(&buf, buf1, PAGE_SIZE); | |
| 396 | + if (len <= 0 || len >= IDMAP_NAMESZ) | |
| 397 | 397 | goto out; |
| 398 | 398 | memcpy(ent.name, buf1, sizeof(ent.name)); |
| 399 | 399 |