Commit 4b1c83d8c3dd4e11da7e1f4fc8c5cd513b77a0fe

Authored by Daniel Borkmann
Committed by Greg Kroah-Hartman
1 parent 01da9f8b6b

netlink: use jhash as hashfn for rhashtable

[ Upstream commit 7f19fc5e0b617593dcda0d9956adc78b559ef1f5 ]

For netlink, we shouldn't be using arch_fast_hash() as a hashing
discipline, but rather jhash() instead.

Since netlink sockets can be opened by any user, a local attacker
would be able to easily create collisions with the DPDK-derived
arch_fast_hash(), which trades off performance for security by
using crc32 CPU instructions on x86_64.

While it might have a legimite use case in other places, it should
be avoided in netlink context, though. As rhashtable's API is very
flexible, we could later on still decide on other hashing disciplines,
if legitimate.

Reference: http://thread.gmane.org/gmane.linux.kernel/1844123
Fixes: e341694e3eb5 ("netlink: Convert netlink_lookup() to use RCU protected hash table")
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Thomas Graf <tgraf@suug.ch>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

net/netlink/af_netlink.c
... ... @@ -3130,7 +3130,7 @@
3130 3130 .head_offset = offsetof(struct netlink_sock, node),
3131 3131 .key_offset = offsetof(struct netlink_sock, portid),
3132 3132 .key_len = sizeof(u32), /* portid */
3133   - .hashfn = arch_fast_hash,
  3133 + .hashfn = jhash,
3134 3134 .max_shift = 16, /* 64K */
3135 3135 .grow_decision = rht_grow_above_75,
3136 3136 .shrink_decision = rht_shrink_below_30,