Commit 4cb194fd5aa555e65e4af4ddc77315ac59f1520a
Committed by
Greg Kroah-Hartman
Greg Kroah-Hartman
1 parent
397ee6685d
bus: omap_l3_noc: Correct returning IRQ_HANDLED unconditionally in the irq handler
commit c4cf0935a2d8fe6d186bf4253ea3c4b4a8a8a710 upstream. Correct returning IRQ_HANDLED unconditionally in the irq handler. Return IRQ_NONE for some interrupt which we do not expect to be handled in this handler. This prevents kernel stalling with back to back spurious interrupts. Fixes: 2722e56de6 ("OMAP4: l3: Introduce l3-interconnect error handling driver") Acked-by: Nishanth Menon <nm@ti.com> Signed-off-by: Keerthy <j-keerthy@ti.com> Signed-off-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Showing 1 changed file with 6 additions and 2 deletions Side-by-side Diff
drivers/bus/omap_l3_noc.c
| ... | ... | @@ -222,10 +222,14 @@ |
| 222 | 222 | } |
| 223 | 223 | |
| 224 | 224 | /* Error found so break the for loop */ |
| 225 | - break; | |
| 225 | + return IRQ_HANDLED; | |
| 226 | 226 | } |
| 227 | 227 | } |
| 228 | - return IRQ_HANDLED; | |
| 228 | + | |
| 229 | + dev_err(l3->dev, "L3 %s IRQ not handled!!\n", | |
| 230 | + inttype ? "debug" : "application"); | |
| 231 | + | |
| 232 | + return IRQ_NONE; | |
| 229 | 233 | } |
| 230 | 234 | |
| 231 | 235 | static const struct of_device_id l3_noc_match[] = { |