Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit 50417c55562c03e6746b13aee650c2bbb048fea3

Authored by Fabian Frederick
Committed by Linus Torvalds
1 parent 38515c7339
Exists in ti-lsk-linux-4.1.y and in 10 other branches dlt-processor-sdk-linux-03.00.00.04, processor-sdk-linux-02.00.01, smarc-ti-lsk-linux-4.1.y, smarct3x-processor-sdk-04.01.00.06, smarct3x-processor-sdk-linux-02.00.01, smarct3x-processor-sdk-linux-03.00.00.04, smarct4x-800-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-04.01.00.06, smarct4x-processor-sdk-linux-02.00.01, smarct4x-processor-sdk-linux-03.00.00.04

mm/zbud.c: make size unsigned like unique callsite 

zbud_alloc is only called by zswap_frontswap_store with unsigned int len.
Change function parameter + update >= 0 check.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
Acked-by: Seth Jennings <sjennings@variantweb.net>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 2 changed files with 3 additions and 3 deletions Side-by-side Diff

include/linux/zbud.h
Diff comments   View file @ 50417c5
... ... @@ -11,7 +11,7 @@
11 11  
12 12 struct zbud_pool *zbud_create_pool(gfp_t gfp, struct zbud_ops *ops);
13 13 void zbud_destroy_pool(struct zbud_pool *pool);
14   -int zbud_alloc(struct zbud_pool *pool, int size, gfp_t gfp,
  14 +int zbud_alloc(struct zbud_pool *pool, unsigned int size, gfp_t gfp,
15 15 unsigned long *handle);
16 16 void zbud_free(struct zbud_pool *pool, unsigned long handle);
17 17 int zbud_reclaim_page(struct zbud_pool *pool, unsigned int retries);
... ... @@ -247,7 +247,7 @@
247 247 * gfp arguments are invalid or -ENOMEM if the pool was unable to allocate
248 248 * a new page.
249 249 */
250   -int zbud_alloc(struct zbud_pool *pool, int size, gfp_t gfp,
  250 +int zbud_alloc(struct zbud_pool *pool, unsigned int size, gfp_t gfp,
251 251 unsigned long *handle)
252 252 {
253 253 int chunks, i, freechunks;
... ... @@ -255,7 +255,7 @@
255 255 enum buddy bud;
256 256 struct page *page;
257 257  
258   - if (size <= 0 || gfp & __GFP_HIGHMEM)
  258 + if (!size || (gfp & __GFP_HIGHMEM))
259 259 return -EINVAL;
260 260 if (size > PAGE_SIZE - ZHDR_SIZE_ALIGNED - CHUNK_SIZE)
261 261 return -ENOSPC;