Commit 51b97e354ba9fce1890cf38ecc754aa49677fc89

Authored by Kirill A. Shutemov
Committed by Linus Torvalds
1 parent 1afcb6ed0d

kernel: use the gnu89 standard explicitly

Sasha Levin reports:
 "gcc5 changes the default standard to c11, which makes kernel build
  unhappy

  Explicitly define the kernel standard to be gnu89 which should keep
  everything working exactly like it was before gcc5"

There are multiple small issues with the new default, but the biggest
issue seems to be that the old - and very useful - GNU extension to
allow a cast in front of an initializer has gone away.

Patch updated by Kirill:
 "I'm pretty sure all gcc versions you can build kernel with supports
  -std=gnu89.  cc-option is redunrant.

  We also need to adjust HOSTCFLAGS otherwise allmodconfig fails for me"

Note by Andrew Pinski:
 "Yes it was reported and both problems relating to this extension has
  been added to gnu99 and gnu11.  Though there are other issues with the
  kernel dealing with extern inline have different semantics between
  gnu89 and gnu99/11"

End result: we may be able to move up to a newer stdc model eventually,
but right now the newer models have some annoying deficiencies, so the
traditional "gnu89" model ends up being the preferred one.

Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
Singed-off-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

Showing 1 changed file with 3 additions and 2 deletions Side-by-side Diff

... ... @@ -297,7 +297,7 @@
297 297  
298 298 HOSTCC = gcc
299 299 HOSTCXX = g++
300   -HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer
  300 +HOSTCFLAGS = -Wall -Wmissing-prototypes -Wstrict-prototypes -O2 -fomit-frame-pointer -std=gnu89
301 301 HOSTCXXFLAGS = -O2
302 302  
303 303 ifeq ($(shell $(HOSTCC) -v 2>&1 | grep -c "clang version"), 1)
... ... @@ -401,7 +401,8 @@
401 401 KBUILD_CFLAGS := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
402 402 -fno-strict-aliasing -fno-common \
403 403 -Werror-implicit-function-declaration \
404   - -Wno-format-security
  404 + -Wno-format-security \
  405 + -std=gnu89
405 406  
406 407 KBUILD_AFLAGS_KERNEL :=
407 408 KBUILD_CFLAGS_KERNEL :=