Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit 535a914975e79ef24b3b519c52fad351f56a6f08

Authored by Chris Mason
Committed by Greg Kroah-Hartman
1 parent fe716b704f

Btrfs: fix kfree on list_head in btrfs_lookup_csums_range error cleanup 

commit 6e5aafb27419f32575b27ef9d6a31e5d54661aca upstream.

If we hit any errors in btrfs_lookup_csums_range, we'll loop through all
the csums we allocate and free them.  But the code was using list_entry
incorrectly, and ended up trying to free the on-stack list_head instead.

This bug came from commit 0678b6185

btrfs: Don't BUG_ON kzalloc error in btrfs_lookup_csums_range()

Signed-off-by: Chris Mason <clm@fb.com>
Reported-by: Erik Berg <btrfs@slipsprogrammoer.no>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

fs/btrfs/file-item.c
Diff comments   View file @ 535a914
... ... @@ -423,7 +423,7 @@
423 423 ret = 0;
424 424 fail:
425 425 while (ret < 0 && !list_empty(&tmplist)) {
426   - sums = list_entry(&tmplist, struct btrfs_ordered_sum, list);
  426 + sums = list_entry(tmplist.next, struct btrfs_ordered_sum, list);
427 427 list_del(&sums->list);
428 428 kfree(sums);
429 429 }