Commit 589bacbccdb444ca31aebb1128fd8fc0a436151b

Authored by Karl Beldan
Committed by Greg Kroah-Hartman
1 parent 99af830756

mac80211: fix typo in starting baserate for rts_cts_rate_idx

commit c7abf25af0f41be4b50d44c5b185d52eea360cb8 upstream.

It affects non-(V)HT rates and can lead to selecting an rts_cts rate
that is not a basic rate or way superior to the reference rate (ATM
rates[0] used for the 1st attempt of the protected frame data).

E.g, assuming drivers register growing (bitrate) sorted tables of
ieee80211_rate-s, having :
- rates[0].idx == d'2 and basic_rates == b'10100
will select rts_cts idx b'10011 & ~d'(BIT(2)-1), i.e. 1, likewise
- rates[0].idx == d'2 and basic_rates == b'10001
will select rts_cts idx b'10000
The first is not a basic rate and the second is > rates[0].

Also, wrt severity of the addressed misbehavior, ATM we only have one
rts_cts_rate_idx rather than one per rate table entry, so this idx might
still point to bitrates > rates[1..MAX_RATES].

Fixes: 5253ffb8c9e1 ("mac80211: always pick a basic rate to tx RTS/CTS for pre-HT rates")
Signed-off-by: Karl Beldan <karl.beldan@rivierawaves.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -462,7 +462,7 @@
462 462 */
463 463 if (!(rates[0].flags & IEEE80211_TX_RC_MCS)) {
464 464 u32 basic_rates = vif->bss_conf.basic_rates;
465   - s8 baserate = basic_rates ? ffs(basic_rates - 1) : 0;
  465 + s8 baserate = basic_rates ? ffs(basic_rates) - 1 : 0;
466 466  
467 467 rate = &sband->bitrates[rates[0].idx];
468 468