net: Fix more stale on-stack list_head objects.

From: Eric W. Biederman <ebiederm@xmission.com> In the beginning with batching unreg_list was a list that was used only once in the lifetime of a network device (I think). Now we have calls using the unreg_list that can happen multiple times in the life of a network device like dev_deactivate and dev_close that are also using the unreg_list. In addition in unregister_netdevice_queue we also do a list_move because for devices like veth pairs it is possible that unregister_netdevice_queue will be called multiple times. So I think the change below to fix dev_deactivate which Eric D. missed will fix this problem. Now to go test that. Signed-off-by: David S. Miller <davem@davemloft.net>

net: Fix more stale on-stack list_head objects.
From: Eric W. Biederman <ebiederm@xmission.com> In the beginning with batching unreg_list was a list that was used only once in the lifetime of a network device (I think). Now we have calls using the unreg_list that can happen multiple times in the life of a network device like dev_deactivate and dev_close that are also using the unreg_list. In addition in unregister_netdevice_queue we also do a list_move because for devices like veth pairs it is possible that unregister_netdevice_queue will be called multiple times. So I think the change below to fix dev_deactivate which Eric D. missed will fix this problem. Now to go test that. Signed-off-by: David S. Miller <davem@davemloft.net>
Eric W. Biederman · David S. Miller
1 parent 2205a6ea93
Showing 2 changed files with 2 additions and 0 deletions Side-by-side Diff
net/mac80211/iface.c
net/sched/sch_generic.c
@@ -1229,6 +1229,7 @@
 	}
 	mutex_unlock(&local->iflist_mtx);
 	unregister_netdevice_many(&unreg_list);
+	list_del(&unreg_list);
 }
  
 static u32 ieee80211_idle_off(struct ieee80211_local *local,
@@ -839,6 +839,7 @@
  
 	list_add(&dev->unreg_list, &single);
 	dev_deactivate_many(&single);
+	list_del(&single);
 }
  
 static void dev_init_scheduler_queue(struct net_device *dev,
...	...	@@ -1229,6 +1229,7 @@
1229	1229	}
1230	1230	mutex_unlock(&local->iflist_mtx);
1231	1231	unregister_netdevice_many(&unreg_list);
	1232	+ list_del(&unreg_list);
1232	1233	}
1233	1234
1234	1235	static u32 ieee80211_idle_off(struct ieee80211_local *local,
...	...	@@ -839,6 +839,7 @@
839	839
840	840	list_add(&dev->unreg_list, &single);
841	841	dev_deactivate_many(&single);
	842	+ list_del(&single);
842	843	}
843	844
844	845	static void dev_init_scheduler_queue(struct net_device *dev,