Commit 61c22c34c6f80a8e89cff5ff717627c54cc14fd4
1 parent
82a28c794f
Exists in
master
and in
20 other branches
clockevents: remove WARN_ON which was used to gather information
The issue of the endless reprogramming loop due to a too small min_delta_ns was fixed with the previous updates of the clock events code, but we had no information about the spread of this problem. I added a WARN_ON to get automated information via kerneloops.org and to get some direct reports, which allowed me to analyse the affected machines. The WARN_ON has served its purpose and would be annoying for a release kernel. Remove it and just keep the information about the increase of the min_delta_ns value. Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Showing 1 changed file with 8 additions and 10 deletions Side-by-side Diff
kernel/time/tick-oneshot.c
| ... | ... | @@ -43,19 +43,17 @@ |
| 43 | 43 | * and emit a warning. |
| 44 | 44 | */ |
| 45 | 45 | if (++i > 2) { |
| 46 | - printk(KERN_WARNING "CE: __tick_program_event of %s is " | |
| 47 | - "stuck %llx %llx\n", dev->name ? dev->name : "?", | |
| 48 | - now.tv64, expires.tv64); | |
| 49 | - printk(KERN_WARNING | |
| 50 | - "CE: increasing min_delta_ns %ld to %ld nsec\n", | |
| 51 | - dev->min_delta_ns, dev->min_delta_ns << 1); | |
| 52 | - WARN_ON(1); | |
| 53 | - | |
| 54 | - /* Double the min. delta and try again */ | |
| 46 | + /* Increase the min. delta and try again */ | |
| 55 | 47 | if (!dev->min_delta_ns) |
| 56 | 48 | dev->min_delta_ns = 5000; |
| 57 | 49 | else |
| 58 | - dev->min_delta_ns <<= 1; | |
| 50 | + dev->min_delta_ns += dev->min_delta_ns >> 1; | |
| 51 | + | |
| 52 | + printk(KERN_WARNING | |
| 53 | + "CE: %s increasing min_delta_ns to %lu nsec\n", | |
| 54 | + dev->name ? dev->name : "?", | |
| 55 | + dev->min_delta_ns << 1); | |
| 56 | + | |
| 59 | 57 | i = 0; |
| 60 | 58 | } |
| 61 | 59 |