Commit 6743ca71e113f4a2b5ee58b060807974d4d33f8b

Authored by Saran Maruti Ramanara
Committed by Greg Kroah-Hartman
1 parent 15f7f69a6b

net: sctp: fix passing wrong parameter header to param_type2af in sctp_process_param

[ Upstream commit cfbf654efc6d78dc9812e030673b86f235bf677d ]

When making use of RFC5061, section 4.2.4. for setting the primary IP
address, we're passing a wrong parameter header to param_type2af(),
resulting always in NULL being returned.

At this point, param.p points to a sctp_addip_param struct, containing
a sctp_paramhdr (type = 0xc004, length = var), and crr_id as a correlation
id. Followed by that, as also presented in RFC5061 section 4.2.4., comes
the actual sctp_addr_param, which also contains a sctp_paramhdr, but
this time with the correct type SCTP_PARAM_IPV{4,6}_ADDRESS that
param_type2af() can make use of. Since we already hold a pointer to
addr_param from previous line, just reuse it for param_type2af().

Fixes: d6de3097592b ("[SCTP]: Add the handling of "Set Primary IP Address" parameter to INIT")
Signed-off-by: Saran Maruti Ramanara <saran.neti@telus.com>
Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Acked-by: Vlad Yasevich <vyasevich@gmail.com>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

net/sctp/sm_make_chunk.c
... ... @@ -2608,7 +2608,7 @@
2608 2608  
2609 2609 addr_param = param.v + sizeof(sctp_addip_param_t);
2610 2610  
2611   - af = sctp_get_af_specific(param_type2af(param.p->type));
  2611 + af = sctp_get_af_specific(param_type2af(addr_param->p.type));
2612 2612 if (af == NULL)
2613 2613 break;
2614 2614