libceph: retry after authorization failure

If we mark the connection CLOSED we will give up trying to reconnect to this server instance. That is appropriate for things like a protocol version mismatch that won't change until the server is restarted, at which point we'll get a new addr and reconnect. An authorization failure like this is probably due to the server not properly rotating it's secret keys, however, and should be treated as transient so that the normal backoff and retry behavior kicks in. Signed-off-by: Sage Weil <sage@newdream.net>

libceph: retry after authorization failure
If we mark the connection CLOSED we will give up trying to reconnect to this server instance. That is appropriate for things like a protocol version mismatch that won't change until the server is restarted, at which point we'll get a new addr and reconnect. An authorization failure like this is probably due to the server not properly rotating it's secret keys, however, and should be treated as transient so that the normal backoff and retry behavior kicks in. Signed-off-by: Sage Weil <sage@newdream.net>
Sage Weil
1 parent 38815b7802
Showing 1 changed file with 0 additions and 2 deletions Side-by-side Diff
net/ceph/messenger.c
@@ -1248,8 +1248,6 @@
 		     con->auth_retry);
 		if (con->auth_retry == 2) {
 			con->error_msg = "connect authorization failure";
-			reset_connection(con);
-			set_bit(CLOSED, &con->state);
 			return -1;
 		}
 		con->auth_retry = 1;
...	...	@@ -1248,8 +1248,6 @@
1248	1248	con->auth_retry);
1249	1249	if (con->auth_retry == 2) {
1250	1250	con->error_msg = "connect authorization failure";
1251		- reset_connection(con);
1252		- set_bit(CLOSED, &con->state);
1253	1251	return -1;
1254	1252	}
1255	1253	con->auth_retry = 1;