Commit 6abb2dd92868927c1d680546b9d13f208373d517

Authored by Joel Stanley
Committed by Rusty Russell
1 parent d1b8c4c257

tools/virtio: fix missing kmemleak_ignore symbol

In commit bb478d8b167 virtio_ring: plug kmemleak false positive,
kmemleak_ignore was introduced. This broke compilation of virtio_test:

  cc -g -O2 -Wall -I. -I ../../usr/include/ -Wno-pointer-sign
    -fno-strict-overflow -fno-strict-aliasing -fno-common -MMD
    -U_FORTIFY_SOURCE   -c -o virtio_ring.o ../../drivers/virtio/virtio_ring.c
  ../../drivers/virtio/virtio_ring.c: In function ‘vring_add_indirect’:
  ../../drivers/virtio/virtio_ring.c:177:2: warning: implicit declaration
  of function ‘kmemleak_ignore’ [-Wimplicit-function-declaration]
    kmemleak_ignore(desc);
    ^
  cc   virtio_test.o virtio_ring.o   -o virtio_test
  virtio_ring.o: In function `vring_add_indirect':
  tools/virtio/../../drivers/virtio/virtio_ring.c:177:
  undefined reference to `kmemleak_ignore'

Add a dummy header for tools/virtio, and add #incldue <linux/kmemleak.h>
to drivers/virtio/virtio_ring.c so it is picked up by the userspace
tools.

Signed-off-by: Joel Stanley <joel@jms.id.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

Showing 2 changed files with 4 additions and 0 deletions Side-by-side Diff

drivers/virtio/virtio_ring.c
... ... @@ -23,6 +23,7 @@
23 23 #include <linux/slab.h>
24 24 #include <linux/module.h>
25 25 #include <linux/hrtimer.h>
  26 +#include <linux/kmemleak.h>
26 27  
27 28 #ifdef DEBUG
28 29 /* For development, we want to crash whenever the ring is screwed. */
tools/virtio/linux/kmemleak.h
  1 +static inline void kmemleak_ignore(const void *ptr)
  2 +{
  3 +}