Commit 6b270fd4db08fc13683d616a733d9cacdd3b4afa
Committed by
Greg Kroah-Hartman
Greg Kroah-Hartman
1 parent
2c3fbe3cf2
Exists in
ti-lsk-linux-4.1.y
and in
10 other branches
TTY: bfin_jtag_comm: remove incorrect wait_until_sent operation
Remove incorrect and redundant wait_until_sent operation, which waits for the driver buffer rather than any hardware buffers to drain, something which is already taken care of by the tty layer (and chars_in_buffer). Signed-off-by: Johan Hovold <johan@kernel.org> Reviewed-by: Peter Hurley <peter@hurleysoftware.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Showing 1 changed file with 0 additions and 13 deletions Side-by-side Diff
drivers/tty/bfin_jtag_comm.c
| ... | ... | @@ -210,18 +210,6 @@ |
| 210 | 210 | return circ_cnt(&bfin_jc_write_buf); |
| 211 | 211 | } |
| 212 | 212 | |
| 213 | -static void | |
| 214 | -bfin_jc_wait_until_sent(struct tty_struct *tty, int timeout) | |
| 215 | -{ | |
| 216 | - unsigned long expire = jiffies + timeout; | |
| 217 | - while (!circ_empty(&bfin_jc_write_buf)) { | |
| 218 | - if (signal_pending(current)) | |
| 219 | - break; | |
| 220 | - if (time_after(jiffies, expire)) | |
| 221 | - break; | |
| 222 | - } | |
| 223 | -} | |
| 224 | - | |
| 225 | 213 | static const struct tty_operations bfin_jc_ops = { |
| 226 | 214 | .open = bfin_jc_open, |
| 227 | 215 | .close = bfin_jc_close, |
| ... | ... | @@ -230,7 +218,6 @@ |
| 230 | 218 | .flush_chars = bfin_jc_flush_chars, |
| 231 | 219 | .write_room = bfin_jc_write_room, |
| 232 | 220 | .chars_in_buffer = bfin_jc_chars_in_buffer, |
| 233 | - .wait_until_sent = bfin_jc_wait_until_sent, | |
| 234 | 221 | }; |
| 235 | 222 | |
| 236 | 223 | static int __init bfin_jc_init(void) |