drm/i915: show unknown sdvox registers on hdmi init

This will throw a BUG() message when an unknown sdvox register is given to intel_hdmi_init. When this happens, things could going to be pretty much broken afterwards, so we better detect this as soon as possible. Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>

drm/i915: show unknown sdvox registers on hdmi init
This will throw a BUG() message when an unknown sdvox register is given to intel_hdmi_init. When this happens, things could going to be pretty much broken afterwards, so we better detect this as soon as possible. Signed-off-by: Eugeni Dodonov <eugeni.dodonov@intel.com> Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Eugeni Dodonov · Daniel Vetter
1 parent 5826eca5ac
Showing 1 changed file with 4 additions and 0 deletions Side-by-side Diff
drivers/gpu/drm/i915/intel_hdmi.c
@@ -661,6 +661,10 @@
 		intel_encoder->clone_mask = (1 << INTEL_HDMIF_CLONE_BIT);
 		intel_hdmi->ddc_bus = GMBUS_PORT_DPD;
 		dev_priv->hotplug_supported_mask |= HDMID_HOTPLUG_INT_STATUS;
+	} else {
+		/* If we got an unknown sdvox_reg, things are pretty much broken
+		 * in a way that we should let the kernel know about it */
+		BUG();
 	}
  
 	intel_hdmi->sdvox_reg = sdvox_reg;
...	...	@@ -661,6 +661,10 @@
661	661	intel_encoder->clone_mask = (1 << INTEL_HDMIF_CLONE_BIT);
662	662	intel_hdmi->ddc_bus = GMBUS_PORT_DPD;
663	663	dev_priv->hotplug_supported_mask \|= HDMID_HOTPLUG_INT_STATUS;
	664	+ } else {
	665	+ /* If we got an unknown sdvox_reg, things are pretty much broken
	666	+ * in a way that we should let the kernel know about it */
	667	+ BUG();
664	668	}
665	669
666	670	intel_hdmi->sdvox_reg = sdvox_reg;