Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit 7205c36680c5aedffbec9b49a9a7e8310da10354

Authored by Jan Kara
Committed by Greg Kroah-Hartman
1 parent 27a7bcd561

rbd: Fix error recovery in rbd_obj_read_sync() 

commit a8d4205623ae965e36c68629db306ca0695a2771 upstream.

When we fail to allocate page vector in rbd_obj_read_sync() we just
basically ignore the problem and continue which will result in an oops
later. Fix the problem by returning proper error.

CC: Yehuda Sadeh <yehuda@inktank.com>
CC: Sage Weil <sage@inktank.com>
CC: ceph-devel@vger.kernel.org
Coverity-id: 1226882
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Ilya Dryomov <idryomov@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 1 additions and 1 deletions Side-by-side Diff

... ... @@ -3382,7 +3382,7 @@
3382 3382 page_count = (u32) calc_pages_for(offset, length);
3383 3383 pages = ceph_alloc_page_vector(page_count, GFP_KERNEL);
3384 3384 if (IS_ERR(pages))
3385   - ret = PTR_ERR(pages);
  3385 + return PTR_ERR(pages);
3386 3386  
3387 3387 ret = -ENOMEM;
3388 3388 obj_request = rbd_obj_request_create(object_name, offset, length,