Commit 736c4b8572ac24b1e6fd58d00872305a120ac700

Authored by Mika Kukkonen
Committed by Linus Torvalds
1 parent 3316eaa31e

[PATCH] Function v9fs_get_idpool returns int, not u32 as called twice in fs/9p/vfs_inode.c

Function v9fs_get_idpool returns int, not u32.  Actually it returns -1 on
errors, and these two callers check if the value is smaller than 0, which
was caught by gcc with extra warning flags.  Compile tested only but should
be OK, as the value computed in v9fs_get_idpool() is also int.

Signed-of-by: Mika Kukkonen <mikukkon@iki.fi>
Cc: Eric Van Hensbergen <ericvh@gmail.com>
Cc: Ron Minnich <rminnich@lanl.gov>
Cc: Latchesar Ionkov <lucho@ionkov.net>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Showing 1 changed file with 2 additions and 2 deletions Side-by-side Diff

... ... @@ -256,7 +256,7 @@
256 256 v9fs_create(struct v9fs_session_info *v9ses, u32 pfid, char *name, u32 perm,
257 257 u8 mode, char *extension, u32 *fidp, struct v9fs_qid *qid, u32 *iounit)
258 258 {
259   - u32 fid;
  259 + int fid;
260 260 int err;
261 261 struct v9fs_fcall *fcall;
262 262  
... ... @@ -310,7 +310,7 @@
310 310 v9fs_clone_walk(struct v9fs_session_info *v9ses, u32 fid, struct dentry *dentry)
311 311 {
312 312 int err;
313   - u32 nfid;
  313 + int nfid;
314 314 struct v9fs_fid *ret;
315 315 struct v9fs_fcall *fcall;
316 316