mfd: tps65910: Fix regmap_irq_chip_data leak on mfd_add_devices fail

The tps65910_i2c_probe() allocates regmap_irq_chip in tps65910_irq_init() but it does not clean this up in case of mfd_add_devices() failure. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>

mfd: tps65910: Fix regmap_irq_chip_data leak on mfd_add_devices fail
The tps65910_i2c_probe() allocates regmap_irq_chip in tps65910_irq_init() but it does not clean this up in case of mfd_add_devices() failure. Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com> Signed-off-by: Lee Jones <lee.jones@linaro.org>
Krzysztof Kozlowski · Lee Jones
1 parent 483e2dfdbc
Showing 1 changed file with 1 additions and 0 deletions Side-by-side Diff
drivers/mfd/tps65910.c
@@ -511,6 +511,7 @@
 			      regmap_irq_get_domain(tps65910->irq_data));
 	if (ret < 0) {
 		dev_err(&i2c->dev, "mfd_add_devices failed: %d\n", ret);
+		tps65910_irq_exit(tps65910);
 		return ret;
 	}
...	...	@@ -511,6 +511,7 @@
511	511	regmap_irq_get_domain(tps65910->irq_data));
512	512	if (ret < 0) {
513	513	dev_err(&i2c->dev, "mfd_add_devices failed: %d\n", ret);
	514	+ tps65910_irq_exit(tps65910);
514	515	return ret;
515	516	}
516	517