Eric Lee / smarc-ti-linux-kernel

Download as
Browse Code ยป

Commit 7a66eeb23e48f93cab7f6a9b9fe9ce6371b57f08

Authored by Geert Uytterhoeven
Committed by Greg Kroah-Hartman
1 parent 25bcda837a

ARM: shmobile: sh73a0 legacy: Set .control_parent for all irqpin instances 

commit b0ddb319db3d7a1943445f0de0a45c07a7f3457a upstream.

The sh73a0 INTC can't mask interrupts properly most likely due to a
hardware bug. Set the .control_parent flag to delegate masking to the
parent interrupt controller, like was already done for irqpin1.

Without this, accessing the three-axis digital accelerometer ADXL345
on kzm9g through /dev/input/event1 causes an interrupt storm, which
requires a power-cycle to recover from.

This was inspired by a patch for arch/arm/boot/dts/sh73a0.dtsi from
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Fixes: 341eb5465f67437a ("ARM: shmobile: INTC External IRQ pin driver on sh73a0")
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Showing 1 changed file with 3 additions and 0 deletions Side-by-side Diff

arch/arm/mach-shmobile/setup-sh73a0.c
Diff comments   View file @ 7a66eeb
... ... @@ -598,6 +598,7 @@
598 598  
599 599 static struct renesas_intc_irqpin_config irqpin0_platform_data = {
600 600 .irq_base = irq_pin(0), /* IRQ0 -> IRQ7 */
  601 + .control_parent = true,
601 602 };
602 603  
603 604 static struct resource irqpin0_resources[] = {
... ... @@ -659,6 +660,7 @@
659 660  
660 661 static struct renesas_intc_irqpin_config irqpin2_platform_data = {
661 662 .irq_base = irq_pin(16), /* IRQ16 -> IRQ23 */
  663 + .control_parent = true,
662 664 };
663 665  
664 666 static struct resource irqpin2_resources[] = {
... ... @@ -689,6 +691,7 @@
689 691  
690 692 static struct renesas_intc_irqpin_config irqpin3_platform_data = {
691 693 .irq_base = irq_pin(24), /* IRQ24 -> IRQ31 */
  694 + .control_parent = true,
692 695 };
693 696  
694 697 static struct resource irqpin3_resources[] = {